catch gelf exceptions [#1408254]

Currently, the gelf library may throw exceptions which are uncaught and can cause problems. The gelf module should catch gelf library exceptions.

Comment	File	Size	Author
#2	catch_gelf_library_exceptions-1408254-2.patch	593 bytes	pdrake
#1	catch_gelf_library_exceptions-1408254-1.patch	551 bytes	pdrake

Comments

pdrake commented 17 January 2012 at 18:59

Status	File	Size
new	catch_gelf_library_exceptions-1408254-1.patch	551 bytes

pdrake commented 17 January 2012 at 19:57

Status	File	Size
new	catch_gelf_library_exceptions-1408254-2.patch	593 bytes

This patch is the same as above but fixes some violations of the drupal coding standards.

jeffsheltren commented 23 January 2012 at 17:44

Assigned:	Unassigned	» jeffsheltren
Status:	Active	» Needs review

Thanks, I'll do a quick test and push this patch to git.

borgenk commented 1 February 2012 at 09:04

Sending error message to everyone is not always preferable. drupal_set_message() should be wrapped in user_access().

jeffsheltren commented 21 February 2012 at 19:23

Status:

Needs review

» Closed (fixed)

Thanks, pushed to 6.x-1.x-dev git. Also wrapped the admin errors with a user_access.