Closed (fixed)
Project:
GELF
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 May 2011 at 17:18 UTC
Updated:
26 Aug 2011 at 17:31 UTC
Jump to comment: Most recent file
There is a typo in the module which prevents it from functioning. I will attach a patch here in a few moments.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | library_path_typo_and_error_checking-1156856.patch | 2.35 KB | pdrake |
Comments
Comment #1
pdrake commentedI suppose it isn't a very helpful bug report if I don't say where the typo is. It is in the path to the library - there is an extra ")" at the end of the path. The attached patch also adds some basic error messages & exception handling that helped me get this working.
Comment #2
msonnabaum commentedI took the typo fix, but the rest is questionable.
Please don't include other issues in your patches as it makes them very difficult to review. Also, please run them through coder because this one has many coding standard violations.
Comment #3
pdrake commentedThanks for the comments. I'll make an effort to keep issues separate and run through coder prior to submission of patches.