Hi,

the module load the js of lightbox2 in a wrong order. Note that on two different installation the js files are listed in different order.

The js are loaded in the order the checkboxes are displayed but that's not the right order.

Some way of ordering the gallery_assist_lightboxes_files variable data should be found, example using multiple select boxes instead of checkboxes would allow to change the order the files will be selected.

CommentFileSizeAuthor
#14 gallery_assist.tar_.gz158.09 KBjcmc
#9 error-colorbox.txt477 bytessuffering drupal
#6 order-in-head.txt1.87 KBsuffering drupal

Comments

fw_crocodile’s picture

fw_crocodile commented
Title: lightbox2 wrong js Order » Wrong JS Order

So,

actually i can make lightbox2 working by reverting to the old behaviour:

decommenting drupal_add_css() and drupal_add_js() and commenting the call to the functiongallery_assist_get_includes($hilfo) that cause the script to be loaded in the wrong order.

I don't know why but the close image isn't displayed.

Anselmo

fw_crocodile’s picture

fw_crocodile commented
Title: Wrong JS Order » lightbox2 Wrong JS Order
fw_crocodile’s picture

fw_crocodile commented
Title: lightbox2 Wrong JS Order » lightbox2 wrong js Order

I just change the title to be more meaningfull.

jcmc’s picture

jcmc commented
Title: Wrong JS Order » lightbox2 wrong js Order
Status: Active » Fixed

fixed with update

jcmc

suffering drupal’s picture

suffering drupal commented

Hi I have been trying for several days now to get Gallery Assist working and I have bumped in into one error after the other, at least on my sites (not just one).... First I had a JQuery crash: collapsible menus didn't work anymore, nor Gmaps or WYSIWYG. It seemed to clash either with Node-Gallery, Lightbox2 or Imagecache. Anyway, after deactivating, reinstalling and trying again I have it working without crash.

And now I try to get it to work with lightbox2.
At http://riccardobarbieri.com/about-me/environment/imagegallery you can see it opens up the image file instead of showing a lightbox.
I followed your video step by step, but it's not working as it should. ImageCache, Lightbox2 and Node Gallery are not active.

Is it because of the order of the scripts in the lightbox settings? I have:

- lightbox.js
- prototype.js
- scriptaculous.js
- effects.js
- builder.js

while at http://www.huddletogether.com/projects/lightbox2/ it says:

script type="text/javascript" src="js/prototype.js"
script type="text/javascript" src="js/scriptaculous.js?load=effects,builder"
script type="text/javascript" src="js/lightbox.js"

and in your video the order is
- prototype
- scriptaculous
- builder
- lightbox
- effects

I am using the latest download of Gallery Assist lightboxes.... (6.x.-1.2 2009-nov-29)

Un saludo!

suffering drupal’s picture

suffering drupal commented
StatusFileSize
new order-in-head.txt1.87 KB

Attached, the code as it appears in "head".

suffering drupal’s picture

suffering drupal commented

Now also tried with PrettyPhoto.
Since there is no further explanation I just supposed it goes in the sites/all/modules/gallery_assist_lightboxes/lightboxes directory, just like lightbox2 (renaming to just "lightbox"). Then I followed your video about replacing standard Jquery with a new download of Jquery-1.3.2-min.
PrettyPhoto does appear in the dropdownbox at admin/settings/gallery_assist/extras, but the "settings" options don't appear and again, galleries open up as normal galleries...
I'l keep on trying with some other lightbox, but frankly my expectance is low.

jcmc’s picture

jcmc commented

Hola y mucho gusto,

from November 11 this was done. I do not understand why you have an older version or a version with the wrong order?

http://drupalcode.org/viewvc/drupal/contributions/modules/gallery_assist...

You can see, the order is the same as by the http://www.huddletogether.com/projects/lightbox2.

and when I download the actualy Gallery Assist Lightboxes I get the right files.

por favor informame que es lo que pasa
Juan Carlos

suffering drupal’s picture

suffering drupal commented
StatusFileSize
new error-colorbox.txt477 bytes

Trying with ColorBox, get an error... attached
I've had it, I'll just forget about lightboxes!

fw_crocodile’s picture

fw_crocodile commented

Colorbox function properly.
You can see it at http://wrench.darviniano.eu/dueruote/node/73 for example.

You should install jquery update module 6.x-2.x-dev

extract colorbox, copy colorbox.css and images folder in colorbox/colorbox then put colorbox/colorbox folder in lightboxes/

so you should have

lightboxes/colorbox/
lightboxes/colorbox/colorbox.css
lightboxes/colorbox/images
ecc...

In the admin settings page, select colorbox.css and the min version of the js.

This should be sufficient and work perfectly for me.

Feel free to ask if you need some help.

suffering drupal’s picture

suffering drupal commented

Downloaded the latest version of Gallery Assist Lightboxes (6.x-1.2).
Now the lightbox settings don't show up, just like the first times I tried to use Gallery Assist...
I'm really getting very confused and tired.

For trying to use the other lightboxes (Colorbox, Lytebox, PrettyPhoto) I substituted the JQuery file as indicated in your video. But I didn't really know what to do with the "....box" files. I supposed under sites/all/modules/gallery_assist_lightboxes/lightboxes. ¿¿¿Is that OK???
Anyway, they don't work either. With or without the adapted JQuery file... Lightbox2 neither.

¿Que hago?

suffering drupal’s picture

suffering drupal commented

@fw_crocodile
I may give this a last try for today or else tomorrow..... Sono stufo!
for the moment I get "Fatal error: Call to undefined function gallery_assist_image_more_info() in /public_html/sites/all/modules/gallery_assist_lightboxes/gallery_assist_lightboxes_display.inc on line 381"

I sent the former message (#11) before seeing yours..
Grazie!

suffering drupal’s picture

suffering drupal commented

I've done the JQuery update. I have put the colorbox files in their place. I've done an update. Flushed all Caches....

AND NOW I STILL GET: "Fatal error: Call to undefined function gallery_assist_image_more_info() in public_html/sites/all/modules/gallery_assist_lightboxes/gallery_assist_lightboxes_display.inc on line 381"
on the homepage!!!

De-activitating Gallery Assist Lightboxes doesn't help....

Only de-activating Gallery Assist as a whole.
Problem comes back on reactivating Gallery Assist.

That's it! I've had it. Sono stufo. Estoy hasta los huevos!
I'd better had stuck to plain HTML.

jcmc’s picture

jcmc commented
StatusFileSize
new gallery_assist.tar_.gz158.09 KB

jajajaja Riccardo,

hast meine Mitteilungen nicht gelesen oder was?

no te diste cuenta que quitaron desde drupal todos los releases hasta el 7?
Algo anda mal o con el cvs o con el modulo, mientras que no me avicen no puedo avisar
(de donde eres tu?)

I send you here the latest version I have commited y que acabo de installar probar without errors.

no hesitate y frage mich que siempre que puedo ayudo

regards
Juan Carlos

suffering drupal’s picture

suffering drupal commented

Vielen Dank für deine Antwort. Morgen wird ich es weiter versuchen, weil ich heute schon müde bin.
Nací en Italia pero me he criao en Holanda. Y ahora llevo muchos años en Sevilla.
I'll try and I'll tell, tomorrow, I've had it for today!

suffering drupal’s picture

suffering drupal commented

@jcmc
The tar file you sent turns out to be the same as I already had "working" on my site: 6.x-1.8-beta1
Activating Gallery Assist gives the same error again:
"Fatal error: Call to undefined function gallery_assist_image_more_info() in public_html/sites/all/modules/gallery_assist_lightboxes/gallery_assist_lightboxes_display.inc on line 381"

Line 381 says: $img = gallery_assist_image_more_info($type, $img, $conf);

On the other hand you sent me this reference:
http://drupalcode.org/viewvc/drupal/contributions/modules/gallery_assist...

I am afraid I don't know what it is and what to do with it.

I'll just try to eliminate everything from the server and start over again. For the last time, though, can't stay stuck on the same stuff more than a week...

suffering drupal’s picture

suffering drupal commented

Deleted all Gallery Assist files from the server...
Uploaded last version (? not sure anymore...)
Working! Thumbnails appear on homepage and inner pages. Can go through the photos one by one. (riccardobarbieri.com)
We're back at the stage of about a week ago.
This will be my 0 option.

NOW, I would just like to show the gallery in a lightbox.....
Trying again with Lightbox(2). Doesn't work, settings don't show up. Why not???
was going to try directly with other lightbox type but accidently saved this configuration.
And it turns out it WORKS!!!! WOWWW, incredible!!

Great! Just some details that worry me.
1 - lightbox settings don't appear (have to check conf)
2 - lightbox opens with image dimensions, doesn't adapt to max size of screen as does original Lightbox2 (like at: http://club8.info/fotoalbum/1983/de-ouwe-doos/maarten-uit-de-oude-doos - very elegant and appreciated, I'll check if it's a CSS thing). No automated slightshow as original Lightbox2. Maybe that is because of the missing settings options.
3 - it seems "next page" doesn't show up anymore on the gallery page
4 - Ordering the images is the way around (es sólo un detalle JCMC, aunque confunda, ya sabes la lógica de Drupal, -10 es lo más alto y 10 es lo más bajo (pesado) )

I go and see if I can discover anything that can be solved/improved and may try other lightboxes as well just to make sure (or would it be better to not touch this kind-of-working configuration? ;)

suffering drupal’s picture

suffering drupal commented

Allright, these are my findings:

Lightbox - YES works, no settings though, images appear full size (large images exceed screen size), no slideshow

Colorbox - YES works, settings appear: using colorbox.css and jquery.colorbox-min.js, images at full size, no slideshow

Prettyphoto - does not work: opens normal image page, settings do appear.... in "Lightboxes for Gallery Assist" menu the Lightboxes dropdown shows "none", but prettyPhoto settings are there..

Lytebox - YES works, no settings, Images ADAPT TO WINDOW-SIZE!!!, slightshow through Lyteshow!!! (no settings).

This clearly surpasses my 70% aim (within the never 100% possibilities in Drupal) so I can finally get on with the next step.
My choice for the moment is Lyteshow (even without setting options). If you want you can check at http://riccardobarbieri.com
Cheers from Seville!

fw_crocodile’s picture

fw_crocodile commented

To adapt colorbox window you have tu use colorbox parameters in the js selector.

See gallery_assist_lightboxes/js/gallery_assist.colorbox.selector.js

and colorbox documentation on the colorbox web site.

This is, for example, my personal conf:

$(document).ready(function() {
  $("a.cboxelement").colorbox({
      //slideshow   : true,
      maxWidth: '90%',
      maxHeight: '90%',
      transition  : "fade", // elastic, fade, none
      speed: '300', // ms
  });
});
suffering drupal’s picture

suffering drupal commented

Hello again.
@cocodrilo - Didn't check your code yet, I'm happy how it goes with Lyteshow for the moment.
Also got it kind of working where it counts at:
http://cordoba.on-map.net/en/monuments-and-buildings/the-cordoba-mosque-...

- working through Image Cache
- working on our custom "on-map item" type page (at riccardobarbieri.com problems to work with "Page type" page - not Image Cache)
- gets propagated to other language pages!! :-)

Main new problems:
- Suddenly the Taxonomy pages where GA is active have disappeared :(
"Page not found" error 500 for term "monuments and buildings" for example.. http://cordoba.on-map.net/en/monuments-and-buildings
I'll have to check taxonomy better to see if I can solve, also try with the new version, so still investigating

- newly uploaded images to existing Gallery don't seem to be recognized: In fact on the indicated page only the last image opens the slideshow correctly, and then you can only go forward (image 2 of 7 it says, but there are 11!!! the first session was a serie of 6, all well, but new pictures not good). The pictures do not show up through the textlink either...

- still something strange in the order of the images. seems the numbers now are all right in the input, but opposite in the output!

Minor newly discovered problems:
- I would like to use a border around the whole of the imagebox (image+text) but it seems image container max-width is determined on beforhand and not leaving any extra margin for an extra border, so the last images goes one line down (without border all on the same line).
I tried to add +20px in gallery_assist_display.inc on line 98 but I don't know the syntaxis....
$my_attr_array = array(
'style' => 'max-width:'. $node->gallconf[$node->type]['container_width'] .'px;',
);

@ JCMC If you can help with that one it would be great.
You don't count with the "Extra thumbnail custom size" if greater than 0 then it goes out of the boundaries of max-width of the container as well.

- Another thing would be path-aliases for the picture pages - nice for SEO!

I'll be on it this weekend (puenteeee!!!)

jcmc’s picture

jcmc commented
Category: bug » support
Priority: Critical » Normal
Status: Fixed » Active

Hi suffering drupal,

I investigated your site and found. Your problem is sitting in front of your computer. ;-)

You use imagecache but delete originals. Why???
This produce a change of category.

You posted here the example -> http://club8.info/fotoalbum/1983/de-ouwe-doos/maarten-uit-de-oude-doos
you can compare
the page : http://club8.info/fotoalbum/1983/de-ouwe-doos/maarten-uit-de-oude-doos
a thumbnail : http://club8.info/sites/default/files/images/tja.thumbnail.jpg
a preview : http://club8.info/sites/default/files/images/tja.jpg

in your case
the page : http://cordoba.on-map.net/en/monuments-and-buildings/the-cordoba-mosque-...
a thumbnail : mezquita-cordoba-12.jpg
a preview : the preview not exist because the original not exist

in the same gallery you can see the preview from mezquita-cordoba-6.jpg I think you create the node, upload the files and before delete the originals you have tested and made a click on this picture.

you see all thumbnails becasue after save drupal show the node node, the browser request the images and ImageCache create the
thumbnails. Then you delete the originals and when you click to see the previews ImageCache have not a original to create the preview. ImageCache have in this case not a reference to create a preset.

In this case
http://riccardobarbieri.com/about-me/environment/imagegallery
you don't use imagecache and all is working but this is not a reason for not using more imagecache.

never mind I help you to jump-start your web galleries this weekend.
Ok?

for the first I need to know the reasons: why you use ImageCache and why you delete the originals?

suffering drupal’s picture

suffering drupal commented

Hi jcmc,
You're right, the originals were not there... But I did not delete them, they just have not been uploaded! I just checked again and the thumbnail is created, but the original is not uploaded. Accessing trough ftp shows that the new images are not in the directory...
Tomorrow I'll try again with another configuration. Tired now |)
-------
I just added new pictures to http://riccardobarbieri.com/about-me/environment/imagegallery (no ImageCache) and it worked ok!
Later I'll try without ImageCache on On-Map. I do not specifically want/need to use ImageCache, I was just experimenting with it. However, I do understand using Cache would be faster for navigating, wouldn't it?

Oh, and something else: the "next" link is missing as you can see, also on On-Map.
Adding "?page=2" works. And in case of adding "?page=3", which does not exist, then the "back" link DOES turn up.... (it seems like some if-then statement is not being excecuted)
-------

Wanted to try to convert http://cordoba.on-map.net/en/monuments-and-buildings/the-cordoba-mosque-... to NON-ImageCache. I disabled all ImageCache elements, but now I get:

Fatal error: Call to undefined function imagecache_preset() in /sites/all/modules/gallery_assist/gallery_assist.module on line 1189 - ¿Is Gallery Assist is still looking for ImageCache?
When activating ImageCache again, the error disappears, but then Gallery Assist again only offers ImageCache options... :(
------
Anyway the worst thing is that the taxonomy pages are still lost. Unfortunately, since I have made so many changes I now don't know if it's related to Gallery Assist, to ImageCache or to some other change.