Enhanced gallery.module

good work !!
juste some questions and comments:

- what does the "Use Full Names" feature you talk about ? (I don't have profile.module and can not test it) ?

- why did you alter
gallery_error(t('Error deleting Gallery user'), $ret); (L 126 on 1.10)
to
gallery_error(t('Error deleting Gallery user')); (L 182 on patched file)

- It is a shame to not be able to unselect every image data in the gallery block. there is a fix in my patch to do it work and avoid ' implode()' warning.

- I enjoy to be able to select multiple gallery block contents and to have the gallery navigation in the gallery sidebar !

- I just disagree to have to alter the main.php, could we not find another way?

thanks foryou work

Dpdev

very very nice. +1 on the mods.

I did use your patch, so this should work -- I will retest it. Note that I did not use it for the Image Type as you should at least select one, but if you do not it will default to random.
actually, it works, except when it has just been installed (no image type are selected), and we've got a warning on
$params['blocks'] = implode('|', variable_get('gallery_block_block_' . $delta, array('0'=>'randomImage')));
but everything is ok configuring 'gallery block'.

This is awesome! No need to mod the theme to move the sidebar into Drupal now. Great work!

I bugged bharat about it on IRC. He's always mega busy, but hopefully he or walkah will have some time to take a closer look at this. I think it's well worth adding to the official one, but it's not my module. :)

Michelle

There we go, no more patching main.php. Valiant was nice enough to commit the line. Now we just need to get the other stuff into the gallery.module :)

Michelle

Hi,

Thanks for your work! It's a really big improvement...

I have one feature request... would it be possible to make the path (standard 'gallery') configurable? For example, if I prefer to have 'photos' as a path, then I have to go and change the module file manually in several places.

I also have one problem with the module. When I'm not logged in, the embedded gallery works perfectly. However, when I am logged in, I get the following error:

Unable to initialize embedded Gallery
Error (ERROR_MISSING_OBJECT)

* in modules/core/classes/helpers/GalleryUserHelper_medium.class at line 179 (GalleryStatus::error)
* in modules/core/classes/GalleryCoreApi.class at line 506 (GalleryUserHelper_medium::fetchUserByUserName)
* in /var/www/org.absurdistan/www/drupal/modules/gallery.module at line 469 (GalleryCoreApi::fetchUserByUserName)
* in /var/www/org.absurdistan/www/drupal/modules/gallery.module at line 265
* in ??? at line 0
* in /var/www/org.absurdistan/www/drupal/includes/module.inc at line 182
* in /var/www/org.absurdistan/www/drupal/modules/block.module at line 502
* in ??? at line 0
* in /var/www/org.absurdistan/www/drupal/includes/module.inc at line 182
* in /var/www/org.absurdistan/www/drupal/includes/theme.inc at line 864
* in ??? at line 0
* in /var/www/org.absurdistan/www/drupal/includes/theme.inc at line 194
* in /var/www/org.absurdistan/www/drupal/themes/engines/xtemplate/xtemplate.engine at line 190
* in ??? at line 0
* in /var/www/org.absurdistan/www/drupal/includes/theme.inc at line 190
* in /var/www/org.absurdistan/www/drupal/modules/block.module at line 387
* in ??? at line 0
* in /var/www/org.absurdistan/www/drupal/includes/menu.inc at line 354
* in /var/www/org.absurdistan/www/drupal/index.php at line 18

Any idea?

Thanks,
Chris.

The file you attached isn't a patch. If you want to have a hope of having your changes added you should create a valid patch. The code probably needs a little cleanup as well (remove the commented debug code and such.

I highly recommend splitting your new features into separate feature requests and patches to have a higher chance of getting them accepted.

The breadcrumb and navigation block definitely desirable changes. However, I can't get the navigation block working on all views. The site admin view doesn't apply the rewrite rule of 'view item' so your code doesn't see the 'gallery' paramater. Another rewrite rule needs to be added for admin views or your code needs an update. I'm playing with various rewrite rules but haven't solved this yet.

chrisvdb - I've seen that error reported before and I believe it's from not having the image block module activated in Gallery 2.

Michelle

enhanced gallery block works only for the first level navigation.

MichelleC, gingibash,

Thanks for your replies!

MichelleC: the image block module is enabled in Gallery2. In fact, everything works just fine, as long as I don't log in!

gingibash: could you perhaps explain a bit more? The embedded gallery does work correctly when the user is not logged in...

The (test) site is online at http://chris.vandenberghe.org/drupal/photos.

Thanks again for your replies,
Chris.

what i meant by only first level navigation links work is that when you enable gallery sidbar navigation (i use item actions in sidebar) in drupal it shows correctly, displays all item actions and the links work. then when you choose for example edit photo (from gallery navigation block), sidbar suddenly appears in embeded gallery (eventhough i disabled it in g2 themes) and gallery navigation block in drupal shows empty item actions list.

I hope this makes sense. I will try to put this online and let you see for yourself.

If you follow the edit album link while the navigation is being displayed in drupal sidebar, the navigation is shown inside of gallery and not in the sidebar.

When enable the Gallery Navigation Block it makes my side bar take up the whole screen once i enter any gallery pages.

Any ideas?

Tried commenting out width: auto but still the same problem.

I cant even give u a link for an example because the site is live and i just had to disable the block so that it wouldnt break everything.

how can i make a user role and add users which have access to my site but not the gallery module?

To be precise i would like to be able to set roles in drupal which DO and DONT have access to the gallery.

Do for example roles such as:

Full Users - can use full drupal features and can use gallery
Normal Users - can use full drupal features but not view/add to gallery

This page is getting way off topic and hard to follow. I suggest using the integration forums at http://gallery.menalto.com/forum/63 so each question can have its own post and so they get higher visibility than stuck here as responses to an issue.

Michelle

Hi,

I wanted to add taxonomies (and node type display) of images in Gallery. For that I have this as a basic plan :

This is how the Taxonomy is created [using multiple hierarchy]

GalleryVocabulary
-MainAlbumOneTerm
-MainAlbumTwoTerm
--SubAlbumOne
---SubSubAlbumOne

and so on..

One main Vocabulary for the whole gallery
Multiple Terms "AlbumOne" "AlbumTwo" and so on for the Albums in that particular level.

Each album having multiple "albumOne" "albumTwo" etc.. terms for more sub albums..

Each picture can be given more that one taxonomy term, hence linking of pictures in different albums is also possible.

Hope I'm getting through to all of you..

This is the functionality required for the Module that needs to be implemented.

On Installation -
1. Create a taxonomy Vocabulary for the gallery when installed.

On Addition of an Album or Photo
1. Creation of a Taxonomy Term in a theGalleryVocabulary, each time someone creates an album.

2. All photos contained in 'album' are listed under the term 'album'

3. The Item created also initiates the creation of a node type (could be page or story or anything for that matter) with the Title = Title in gallery, Body = Description in Gallery + the 'picture' (with a hyperlink to its gallery counterpart).

this way searches will lead you to picturesnodes and albumnodes, which when clicked on lead you to their respective albums within gallery. thus no duplication, presence within drupal as simple nodes and improved searching for the whole site.

(not sure what to do with the keywords stored in gallery for each pic - need help on that too.. is there any invisible node type? or some such?)
--------------------------

I'm quite new to making modules for drupal, so am not quite sure what exactly I should do now. Could you please recommend some modules that I could look at for this functionality (so that I can take'em apart and put'em back together?):

1. Creation of simple node with a title and body (guessing page.module should do this)

2. Creation of Taxonomy terms on the fly (guessing aggregator_otf.module)

Thanks for all the help!

[this was earlier a forum discussion located at this place. Let me know if I can help in any way.]

-Gautam Chandna

Gautam, I also really need Drupal taxomomy linkage with Gallery. But limiting it to a single "Gallery" vocabulary would not work for me at all. I need full access to all defined vocabularies. Also a Drupal "gallery2" node type would be really nice. I've been considering tackling this myself, but don't want to duplicate work that others may have already started (and I'm still quite new to Drupal coding). I'd love to participate in making this enhancement happen.

Todd

Hey gang... just catching up on this thread.

@kiz_0987 - looks like you've been hard at work on the integration - thanks for the continued efforts.

I have several comments - most importantly though, it would be much easier to manage if we had per-feature patches - since it's much easier to track, and when there are certain things that aren't ready - they won't block other features.

also, there's no need in a patch to comment where your changes are - that's the point of a patch.

please cleanup your patches (removing dprintr's etc - even if commented).

the profille mode (full name) doesn't seem to actaully be documented anywhere which hardcoded profile field you're looking for...

otherwise, i'll look into incorporating the other features ...

This works great for me, once I found the various places for the necessary settings. The only remaining issue is getting it to look nice with my theme. But this is so much better than before. Thanks!

Because the gallery side-bar gets stripped (which gives my site the perfect outlook) I get a javascript error, because gallery checks the search block which off course is stripped. attached the code part which gives the error (site: www.vanrafelghem.be). I don't know if gallery should be paatched for this or you can make a slight adaptation in the module.

Great module. I have a question though. Is the block supposed to show up on all nodes? I was sure it was, but then I moved my default gallerydata directory onto a raid array. I modified the config.php in gallery2 to reflect the change. Gallery2 works fine and the block works fine but only when I'm in sitename/gallery. Short of moving the gallerydata back to it's original location, is there something else I can check. I've verified the block settings are set to show the block on all nodes. I'm obviously missing something.

Well, tried copying gallerydata back to original location. Same results. Maybe it never did show up on all nodes.

As a response to #18 - the width question.

I was having this same problem with my integration.

First I tried commenting out the width: auto line, but that didn't help.

I continued to dig a bit and I found is that if I changed the Item Action links in the sidebar to use a dropdown list, the problem would go away. I think that the HTML there may have a problem that causes the width to go to full size.

Hi,

Great work on this - is exactly what I need. What is the status of the other improvements you mentioned? Also, will this module work with Drupal 4.7?

I've got problems with the Gallery block in this enhanced module.

1. Displaying one random image, the top of the block displays the words "Random Image" twice on seperate lines.
2. I can't get it to display the title of photos. All I get it the filename, even though I've selected Title in the block administration.

Otherwise a good module. Any ideas?

I run a Gallery2 installation with Drupal.

I'm wondering if there's a way to make the Image Block only show specific subdirectories in Gallery2.

There are many users and each user has his own sub-gallery under /gallery2. So I'm wondering if it's possible to modify the image block to only show images specific to that user.

Hey,

I'm always getting this errors:

Unable to initialize embedded Gallery
Error (ERROR_MISSING_OBJECT)
in modules/core/classes/helpers/GalleryUserHelper_medium.class at line 179 (gallerystatus::error)
in modules/core/classes/GalleryCoreApi.class at line 506 (galleryuserhelper_medium::fetchuserbyusername)
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/modules/gallery.module at line 469 (gallerycoreapi::fetchuserbyusername)
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/modules/gallery.module at line 265
in ??? at line 0
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/includes/module.inc at line 182
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/modules/block.module at line 502
in ??? at line 0
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/includes/module.inc at line 182
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/includes/theme.inc at line 864
in ??? at line 0
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/includes/theme.inc at line 194
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/themes/engines/phptemplate/phptemp... at line 210
in ??? at line 0
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/includes/theme.inc at line 190
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/includes/common.inc at line 216
in /usr/data/websites/scheppers/www.commercieelwebverkeer.be/www/typo/index.php at line 21

Grtz

Youri

I've just made the stupid, stupid, stupid mistake of installing the CVS Gallery 2.1 over my existing gallery. I love the enhanced Gallery module, but unfortunately now it's broken (my whole website, actually). Is there any chance that the 2.1 integration changes from http://drupal.org/node/45159 could be quickly hacked into this enhanced Gallery module?

I just installed this and wow, it is fantastic.

One question, before I installed this enhancement the process to upload new images was obvious, now I do not see a link to upload a new image.

Did I do something wrong?

Here is my implementation.

http://www.devotion160.com/gallery

Great module and great enhancements!!

1 small issue, in the gallery navigation block, when i select an album, i get 2 listings of the album list

Gallery
album 1
album 2
album 3

Gallery
album 1
etc

Any Ideas?

Also how do i get rid of the standard gallery header? tried uncommenting the css file to no joy

using ver 1.13 of the kiz0987 gallery.module

Sorry to keep pushing here, but... is this module still in active development? Now that G2.1 RC1 is out, what is the status of 2.1 compatability? This module is sweet as candy, but unfortunately I've made the 2.1 plunge and there's no looking back...

Check out my comment #14
http://drupal.org/node/45159#comment-79711

Basically one of the tasks is to migrate the isError() calls, which is pretty straightforward.
I fixed that part based on stardog's initial "hacks", but I haven't taken a look at what else he did to get it working.

If I had more time I could probably do a diff and patch kiz's module, since it looks like it is superior (no offense) to stardog's (sans Gallery 2.1 support).

Hi. I don't see any options for increasing the number of images in a block on the admin>blocks>gallery block page. How do you set the number of images in a block? Also, is there any way to display them in a horizontal row? alter the drupal_g2.css file?

Thanks!

Please do NOT change the title of issues!!

Back on topic, is there any progress on a 2.1 compatible version of this???

Wow--easy there. First, I was just trying to fill out the "title" field in the form. Apparently you're referring to some unwritten ettiquette not in the formatting guidelines? Second, how is asking about setting the number of pictures in an image block off topic when

2) Allow for multiple images in the block

is listed in the description above?

Sorry to keep pushing here, but... is this module still in active development? Now that G2.1 RC1 is out, what is the status of 2.1 compatability? This module is sweet as candy, but unfortunately I've made the 2.1 plunge and there's no looking back...

I'm not involved into the development. I wrote an email to both developers and got a response. They are working on the module. So be patient, they will be releasing it when it's done.

Just thought I'd let you know. It made me feel a lot better to hear that we're not building our site around an abondoned module.

globo

jivyb -

The problem is that changing the title changes the title on the _entire thread_, not just for your comment like it does in the forums. It's an easy mistake to make and I've done it myself. Just something you need to be careful of when responding on issues.

Michelle

bump.

With the official release of 2.1, can someone PLEASE do a 4.6 module that works with G2.1 ?