Sorry to reopen, but your code in gallery_base.inc states at line 401:
// Workaround for urls containing '&' with @import directive (#157978)
$include = str_replace('&g2_frames', '&g2_frames', $include);
The first two variables of str_replace are backwards, and should be:
// Workaround for urls containing '&' with @import directive (#157978)
$include = str_replace('&g2_frames', '&g2_frames', $include);
@amessina: The code you posted is identical to the existing. Can you please clarify!? What changes are you proposing and why? What is the problem with this line?
I think that the amp part of the code was encoded by Drupal on submission of #4. It looks like amessina was stating that the first 2 arguments to str_replace are the wrong way around. However, looking at the code (and the manual page) it looks right to me -- ie & gets replaced with & which from your gallery bug report looks like what you are trying to achieve.
Comments
Comment #1
profix898 commentedLooks like a problem with the css generated by G2. I will look into this shortly. Thanks.
Comment #2
profix898 commentedSome urls for future reference:
http://gallery.menalto.com/node/66772
http://drupal.org/node/145218
I have just committed a workaround patch for D5. If #145218 goes in, we can remove that code for the D6 version of gallery module.
Comment #3
(not verified) commentedComment #4
amessina commentedSorry to reopen, but your code in gallery_base.inc states at line 401:
// Workaround for urls containing '&' with @import directive (#157978)
$include = str_replace('&g2_frames', '&g2_frames', $include);
The first two variables of str_replace are backwards, and should be:
// Workaround for urls containing '&' with @import directive (#157978)
$include = str_replace('&g2_frames', '&g2_frames', $include);
http://us3.php.net/manual/en/function.str-replace.php
Comment #5
profix898 commented@amessina: The code you posted is identical to the existing. Can you please clarify!? What changes are you proposing and why? What is the problem with this line?
Comment #6
kiz_0987 commentedI think that the amp part of the code was encoded by Drupal on submission of #4. It looks like amessina was stating that the first 2 arguments to str_replace are the wrong way around. However, looking at the code (and the manual page) it looks right to me -- ie
&gets replaced with&which from your gallery bug report looks like what you are trying to achieve.Comment #7
profix898 commentedYep, if thats what this is all about, then we can close the issue, I think.