I really like this theme but some of the formatting could use some work. Namely, the style.css is very inconsistent. I can't find any CSS standards but generally they seem to follow this guideline:

.classname {
  font-weight: bold;
  float: left;
}

Note the two space indent for the actual attributes.

Comments

andregriffin’s picture

andregriffin commented

I'm not sure what you mean by inconsistent. You may want to try understanding what each section actually is. Everything that a user would typically need to edit follows:

.selector {
property:attribute;
}

Everything else (starting with the CSS support classes) follows a different formatting to save file size, mainly because it is info that most users will not need to edit. The last line of the stylesheet is extremely compressed, for the same reason.

If you for some reason want a different formatting, you can easily process it with cleancss.com

brenda003’s picture

brenda003
she/her
commented

Alright. I tend to disagree, as that's what CSS aggregation is for. Also, it seems most Drupal themes do in fact follow the convention of the two spaces for each property attribute. Comments format is also generally:

/**
 * Comment here.
 */

or

/* Comment */

I'm not sure if there's "standards" set, but this seems the common convention and is a lot easier to read. I can supply a patch if desired, but it would essentially be for the whole file...

All in all, though, good base theme, thanks.

BioALIEN’s picture

BioALIEN commented
Priority: Normal » Minor

Andre, I am going to have to agree with brenda003 on this one. I tend to follow the same Drupal coding standards when it comes to doing the html and css. File space savings are achieved via aggregation, caching and gzip.

Changing status to reflect the benefits vs time factor :)

andregriffin’s picture

andregriffin commented
Status: Active » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.