I updated to 3.3 and the imagepicker module no longer displays its four tabs properly on the admin article editor page. The tab text is viewable as links but the tab styling is absent (see attached image). This was working in 3.2, but broke with the changes to style.css in 1.5.2.5.

The change relates to the fact that there are now rules for all ul.primary, ul.secondary, instead of them being tied to #navigation.

I'm new to drupal and not sure what the fix would be. Maybe those specific rules should be reverted since they do only relate to #navigation menus?

(Thanks for your work on framework, btw!)

CommentFileSizeAuthor
Picture 1.png32.59 KBcodeforkjeff

Comments

codeforkjeff’s picture

codeforkjeff commented

I discovered this affects the "tabs" menu also. Log in as an administrator, navigate to an article page (/node/NNN). The "View" and "Edit" links aren't styled correctly.

andregriffin’s picture

andregriffin commented
Status: Active » Closed (works as designed)

Yes, the CSS under the /* tabs */ section in style.css affects only these things, and does not affect main-menu navigation. I wanted to simplify the display of tabs so that it would be easier for people to customize to their liking. If you prefer the default styling of tabs, you may simply remove the CSS under /* tabs */ all the way up to the /* NODES */ section.

codeforkjeff’s picture

codeforkjeff commented

Ah, I see. Thanks for the help! I still wonder if this will be confusing to others--if they called "tabs", they should look like tabs, no? It is a little strange for new drupal users like myself to see those links floating on the page without the tab styling.

andregriffin’s picture

andregriffin commented

I think I agree with you. I'll make some kind of visual distinction to indicate that they're tabs in the next version. I'll post the updated CSS here.

andregriffin’s picture

andregriffin commented
Status: Closed (works as designed) » Fixed

This will make the tabs look nice with minimal override.

/* admin tabs */
.tabs-wrapper {
  margin: 0 0 1.5em;
}

ul.primary {
  margin: 0;
  padding: 0;
}

ul.secondary {
  margin: 0;
  padding: .5em 0;
}

ul.secondary a.active {
  border-bottom: none;
}

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.