In /admin/settings/forward, at least fields with IDs "edit-forward-email-subject" and "edit-forward-email-message" are not updated when the form is saved.

If I input a value to the "edit-forward-email-subject" field, the value gets saved to variable "forward_email_subject" in the database, but the "forward_page_message" variable remains the out-of-the-box-default - and is used to input the value for the field.
Same thing with "edit-forward-email-message", the value gets saved to "forward_email_message" and "forward_page_message" remains the default.

Shouldn't there also be a section in the form to set those email values? Now there's only settings for the defaults for "Email this page" and "ePostcard".

Comments

hd’s picture

hd commented

Same problem here, the changes are not being saved.

yerboo’s picture

yerboo commented

I downgrade to 1.16

hans0811’s picture

hans0811 commented

Indeed, this "solves" the problem.

pydubreucq’s picture

pydubreucq commented

I have the same problem... :(

Bilmar’s picture

Bilmar commented

experiencing the same issue
subscribing

tormu’s picture

tormu commented
Version: 6.x-1.17 » 6.x-1.18

The problem is still in the newest version too, and on the dev-version as well.. Seems to be a duplicate of http://drupal.org/node/886806, which has already been marked as fixed some time ago (which is weird..)

seanr’s picture

seanr
he/him
commented
Status: Active » Fixed

Figured it out, fixed in the release I'm tagging now.

jberube’s picture

jberube commented
Version: 6.x-1.18 » 6.x-1.19

I'm using 6.x-1.19 and when I change the settings for "Forward Page Title:" and "Forward Message Subject:", the changes are still not reflected on the forward form.

Here's what I did to fix mine:

file: forward.module
line 293:
- $form['forward_email_defaults']['forward_email_title'] = array(
+ $form['forward_email_defaults']['forward_page_title'] = array(

line 296:
- '#default_value' => variable_get('forward_email_title', t('Forward this page')),
+ '#default_value' => variable_get('forward_page_title', t('Forward this page')),

line 301:
- $form['forward_email_defaults']['forward_email_subject'] = array(
+ $form['forward_email_defaults']['forward_page_subject'] = array(

line 304:
- '#default_value' => variable_get('forward_email_subject', t('!name has forwarded a page to you from !site')),
+ '#default_value' => variable_get('forward_page_subject', t('!name thought you would like to see this page from the !site web site.')),

Line 309:
- $form['forward_email_defaults']['forward_email_message'] = array(
+ $form['forward_email_defaults']['forward_page_message'] = array(

line 312:
- '#default_value' => variable_get('forward_email_message', t('!name thought you would like to see this page from the !site web site.')),
+ '#default_value' => variable_get('forward_page_message', t('!name thought you would like to see this page from the !site web site.')),

seanr, could you please take a look and see if this makes sense? Thanks for this module, BTW, it's excellent.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Bilmar’s picture

Bilmar commented
Status: Closed (fixed) » Needs review

Setting status to 'needs review' as I do not see a release since Sept 18th (none from Sept 23rd with changes mentioned above).
Seanr - could you please review jberube's work above?

Thank you

ricferr’s picture

ricferr commented
Version: 6.x-1.19 » 6.x-1.16

Hi there,

I'm having the same problem here

Is there a fix for this?

thanks

RF

john.oltman’s picture

john.oltman commented
Status: Needs review » Closed (duplicate)

Duplicate of http://drupal.org/node/886806 which was addressed in 6.x-1.21