DrupalPractice has found some issues with your code, but could be false positives.

Check https://pareview.sh/pareview/https-git.drupal.org-project-forms_steps.git to fix DrupalPractice issues.

CommentFileSizeAuthor
#10 forms_steps-drupalPractice-3013193-10.patch29.02 KBHakimR
#9 forms_steps-drupalPractice-3013193-8.patch29 KBHakimR
#7 forms_steps-drupalPractice-3013193-7.patch28.41 KBHakimR
#5 forms_steps-drupalPractice-3013193-5.patch27.74 KBHakimR
#2 forms_steps-3013193-2.patch18.14 KBjigish.addweb

Comments

HakimR created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new forms_steps-3013193-2.patch18.14 KB

@HakimR, Please find my attached patch which resolves different coding standard issues, hope this works for your requirements.
Thanks!.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: forms_steps-3013193-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

HakimR’s picture

HakimR commented

Hi @jigish.addweb,

Thanks for your contribution. Your patch doesn't pass the tests, it needs work.

Thks,
Hakim

HakimR’s picture

HakimR commented
StatusFileSize
new forms_steps-drupalPractice-3013193-5.patch27.74 KB

New proposition that should not break the module.

  • HakimR committed e5806a4 on feature/FOST-3013193 
    Issue #3013193 by HakimR: Fix DrupalPractice code issues
HakimR’s picture

HakimR commented
StatusFileSize
new forms_steps-drupalPractice-3013193-7.patch28.41 KB

Fix issue on bundleInfo.

  • HakimR committed 9ab0502 on feature/FOST-3013193 
    Issue #3013193 by HakimR: Fix DrupalPractice code issues
HakimR’s picture

HakimR commented
StatusFileSize
new forms_steps-drupalPractice-3013193-8.patch29 KB

More drupalPractices fix included.

HakimR’s picture

HakimR commented
StatusFileSize
new forms_steps-drupalPractice-3013193-10.patch29.02 KB

More drupalPractices fix included.

  • HakimR committed 35c0090 on feature/FOST-3013193 
    Issue #3013193 by HakimR: Fix DrupalPractice code issues

  • HakimR committed 9cea6e8 on 8.x-1.x 
    Issue #3013193 by HakimR, jigish.addweb: Fix DrupalPractice code issues
HakimR’s picture

HakimR commented
Status: Needs work » Fixed
HakimR’s picture

HakimR commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.