After these two issues, we now have a consistent fieldset markup to work with:

- #1404710: Additional CSS to ensure consistent display of field configuration
- #1366878: Fix Form Builder tab display to remove gap and Garland coloring

We should place the validation (and other) messages inside the fieldset-wrapper so that the messages get the same padding around them as the other fields in the fieldset.

CommentFileSizeAuthor
#2 form_builder_message_fix.patch702 bytesquicksketch
form_builder_fieldset_messages.patch1.09 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Committed to both branches.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new form_builder_message_fix.patch702 bytes

Looks like the change broke messages when first opening a field configuration form because the fieldset isn't yet :visible. This patch fixed that problem so that our messages are working when opening a field configuration form again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.