Problem/Motivation

The '<'span'>' and '<'span class'>' entries in footnotes.ckeditor5.yml are incorrect. The plugin uses '<'span'>' only in the editing downcast (widget UI), not in the data downcast (saved HTML). Declaring span elements in the elements list makes the footnotes plugin claim schema ownership of all classed spans, which conflicts with any other plugin or GHS rule that also uses '<'span class'>' (e.g. text styles, inline formatting).

Steps to reproduce

When in ckeditor, try adding in a class that is not related to this module to the span element. It will not take due to this bug.

Proposed resolution

Removing '<'span'>' and '<'span class'>' resolves the conflict without breaking any functionality, since editing-view elements do not need to be declared.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 remove-span-elements-patch.txt368 bytesgmatteo

Comments

gmatteo created an issue. See original summary.

gmatteo’s picture

Status: Active » Needs review
StatusFileSize
new368 bytes
scott_euser’s picture

Version: 4.0.0-beta7 » 4.0.x-dev
Status: Needs review » Needs work

Thanks for raising and for the contribution. Can you please create as a merge request so tests run, add test coverage as appropriate, and provide a link to an example conflicting module along with clear steps to reproduce from a clean drupal 11 install (eg standard profile). Thanks!

scott_euser’s picture

Priority: Critical » Normal
Status: Needs work » Postponed (maintainer needs more info)

With steps to reproduce eg with conflicting module could consider changing severity again...