Hello,
is there a plan for a drupal 8 version of footnotes?

Comments

xmacinfo’s picture

Assigned: butterbrot » Unassigned

Please do not assign yourself to this issue if you do not plan to create the Drupal 8 version.

mariagwyn’s picture

+1 to a D8 version

fl3a’s picture

Hi there,

i just started a footnotes 8.x port sandbox.

Collaborators, co-maintainers and help are very welcome!

Regards

xmacinfo’s picture

Do you consider your port complete?

yukare’s picture

Status: Active » Needs review

I did some work on sandbox and now we have the module working, so please use it from sandbox and test if you have any issue.

About wysiwyg: it will not have a drupal 8 version, as we have the ckeditor on core, i will remove it from module, and add the ckeditor plugin inside footnotes(drupal 8 makes it much more simple than drupal 7).

About views: we do not have it on drupal 7, i plan to remove it and add latter, but i will need some help from someone that uses it in drupal 6 with a real use case(and better if i have a page where i can see it working).

The plan:

  • Add tests for main module.
  • Fix all coding standard.
  • Fix all todo or create issue for then.
  • Remove the wysiwyg and views parts.
  • Ask for commit and releases permission on footnotes, and make a release.
  • Add the ckeditor button plugin back
  • Add views support back.
hingo’s picture

Hi all

I just want a log an informational message, that although I'm no longer active in Drupal, I do still read email and happy to see this progress. It seems to me that none of the people currently active with this D8 port have maintainer rights, and none of the people I made maintainers when I've moved away from Drupal development are active here anymore. I just wanted to let you know that I'm still here and once you feel you have something to be released, I'll make sure to give someone the needed rights to do so.

And goes without saying, I'm happy to see people stepping up to keep this module up to date! I'm still proud of my past contributions to Drupal and it's nice to see people still care about the code.

henrik

yukare’s picture

Now we have tests, so will be more simple to see if something breaks.
Removed wysiwyg and views.
Added a ckeditor plugin, but it is not working now and breaks the ckeditor, so do not use it. I will remove it if is not fixed before a release.

fl3a’s picture

Hi hingo,

as yukare wrote we are good to go, i can verify that the base of footnotes is working, ckeditor integration is in progress und further step as you see in comment #5 are formulated.

So i wanted to ask you for sufficient access to this project for him and me to able to have a initial 8.x release and to move development from my sandbox to a more convenient place.

Regards
Florian

yukare’s picture

Thanks to the work done on https://www.drupal.org/node/2025027 by acrollet and DamienMcKenna now we have the ckeditor button working on drupal 8.

Now only views support is missing, but since it is missing on drupal 7 too, we can move foward. So please, test the module and see if there is any issue or something missing from drupal 7.

One more thing: we do not have an upgrade path, but since we have only one setting per filter it is simple todo again on drupal 8 and i do not want to hold a release on this.

hingo’s picture

Hi

Sounds great! Both of you now have full admin rights to the project, so please go ahead and do everything that needs to be done!

yukare’s picture

I just do not know the correct git commands to import the files from sandbox to project, so i need some help with this. The files are ready to this.

xmacinfo’s picture

yukare’s picture

Thanks, but this is not what i need, i do not want to create a new project, i want to import all changes done in the sandbox to this project. I could create an empty branch here, copy and paste files, commit, but this will make git loose all history.

fl3a’s picture

Hi yukare,

Done, now you might continue with this repository.

Thats were the step i did (within sandbox repo):

Set/change remote from sandbox to this official repo (you migth replace username with yours)

git remote set-url origin fl3a@git.drupal.org:project/footnotes.git

Skip this, i needed to delete first the existing 8.x-2.x branch (dont know why it already existed perhaps a try?!)

git push origin :8.x-2.x

Push our feature branch with our changes.

git push -u origin 8.x-2.x

DONE :D

Thanks again for your Efforts!

fl3a’s picture

Status: Needs review » Fixed

Development moved to here, created 8.x-2.x dev Release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.