I found user could add themselves as friend. Shouldn't flag friend have some sort of validation to check it? i think the validation should be smth like $content->uid != $account->uid, but i not sure where to put it...
should i put it inside 'function flag_friend_flag'?

Comments

cyberwolf’s picture

cyberwolf commented

Same issue here. IMHO it's a bug.

sirkitree’s picture

sirkitree commented
Version: 6.x-1.0-rc4 » 6.x-1.x-dev
Category: bug » feature

moving to dev.

While I understand this is undesirable, I don't really see it as a 'bug'. The module is not breaking, and in fact breaks nothing if a user would friend their self (I think). Unless you can show me this functionality breaking something, I'm marking as a feature request. It's certainly a feature that would make sense to implement.

cyberwolf’s picture

cyberwolf commented

It's not a bug in the sense that it breaks things, but still it is a logical bug IMHO as it is not logical that users can add themselves as their own friend. If it's expected behavior then yes this issue is a feature request and not a bug, but if it's not expected behavior then it's certainly a bug (non-critical, as it does not break functionality).

It's something that will probably need to be fixed on any website with a social aspect using the flag_friend module.

sirkitree’s picture

sirkitree commented
Status: Active » Closed (works as designed)

Looks like nobody was willing to provide a patch for this. Closing due to inactivity.