Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
I see there's a lot of work to do here. The handler itself doesn't work. As for D6: it might be a headache to support both Views 2.x and 3.x because they aren't quite compatible.
In Views 2.x, a validator is a miserable beast: it doesn't have a $this->options[] where settings are stored. This leads to non-straightforward option names and way to reach them.
This was fixed in Views 3.x.
The Drupal 7 patch: We no longer need the #dependency thing (Views handle this for us). We now have option_definition(). We provide migration code.
The Drupal 6 patch: We want to be able to run on Views 2 for a while, so we keep the _get_option() accessor. For consistency between our D6/7 branches we also use this accessor in D7.
Comments
Comment #1
dawehnerHere is a patch.
Comment #2
mooffie commentedIt seems it's not enough to make the dependency work.
Comment #3
mooffie commentedI see there's a lot of work to do here. The handler itself doesn't work. As for D6: it might be a headache to support both Views 2.x and 3.x because they aren't quite compatible.
Comment #4
dawehnerOn which arguments is your oppinion based on?
There are only a few api changes between v3 and v2, really a few.
Comment #5
mooffie commentedOverview:
In Views 2.x, a validator is a miserable beast: it doesn't have a $this->options[] where settings are stored. This leads to non-straightforward option names and way to reach them.
This was fixed in Views 3.x.
The Drupal 7 patch: We no longer need the #dependency thing (Views handle this for us). We now have option_definition(). We provide migration code.
The Drupal 6 patch: We want to be able to run on Views 2 for a while, so we keep the _get_option() accessor. For consistency between our D6/7 branches we also use this accessor in D7.
Comment #6
mooffie commentedComment #7
mooffie commentedCommitted.
http://drupal.org/cvs?commit=467408
http://drupal.org/cvs?commit=467404