Views uses ctools_dependent_process now.

CommentFileSizeAuthor
#5 d7.diff4.42 KBmooffie
#5 d6.diff6.71 KBmooffie
#1 977856-dependency-fix.patch1.71 KBdawehner

Comments

dawehner’s picture

StatusFileSize
new1.71 KB

Here is a patch.

mooffie’s picture

Status: Needs review » Needs work

It seems it's not enough to make the dependency work.

mooffie’s picture

Assigned: Unassigned » mooffie

I see there's a lot of work to do here. The handler itself doesn't work. As for D6: it might be a headache to support both Views 2.x and 3.x because they aren't quite compatible.

dawehner’s picture

On which arguments is your oppinion based on?

There are only a few api changes between v3 and v2, really a few.

mooffie’s picture

Title: Replace views_process_dependency by ctools_dependent_process » Migrate the validator to Views 3
Status: Needs work » Needs review
StatusFileSize
new6.71 KB
new4.42 KB

Overview:

In Views 2.x, a validator is a miserable beast: it doesn't have a $this->options[] where settings are stored. This leads to non-straightforward option names and way to reach them.

This was fixed in Views 3.x.

The Drupal 7 patch: We no longer need the #dependency thing (Views handle this for us). We now have option_definition(). We provide migration code.

The Drupal 6 patch: We want to be able to run on Views 2 for a while, so we keep the _get_option() accessor. For consistency between our D6/7 branches we also use this accessor in D7.

mooffie’s picture

Title: Migrate the validator to Views 3 » Port the validator to Views 3
mooffie’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.