Here is a integration with flag module

Conditions:
1) When viewing flagged node with specific flag
2) When viewing flagged user

Any ideas how to make it better?

Patch against DRUPAL-3 not beta5

CommentFileSizeAuthor
#5 flag_context-d6.patch5.87 KBandypost
#4 flag_context.zip2.48 KBandypost
#4 flag_context-d6.patch5.93 KBandypost
#3 flag_context.zip2.48 KBandypost
#3 flag_context-d6.patch5.93 KBandypost
#1 831390-context-flag.patch5.81 KBandypost
context_flag.patch5.79 KBandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 831390-context-flag.patch5.81 KB

Parent class was wrong and $flag->is_flagged should accept $content_id for node

yhahn’s picture

yhahn commented
Version: 6.x-3.0-beta5 » 6.x-3.x-dev
Status: Needs review » Needs work

The code looks good -- would be great in a separate contrib module or in the flag project itself. Leaving open for you to close when the code finds a home.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Flag modules support » Flag and context modules integration
Project: Context » Flag
Version: 6.x-3.x-dev » 6.x-1.x-dev
Component: Code » Miscellaneous
Assigned: Unassigned » andypost
Status: Needs work » Needs review
StatusFileSize
new flag_context-d6.patch5.93 KB
new flag_context.zip2.48 KB

Suppose this module is too small to be a standalone. So let's try push into flag module

This module works with flag of both versions 6.1 and 6.2

PS: there's a still TODO in plugins because condition_used() method already in cvs but no release been made

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new flag_context-d6.patch5.93 KB
new flag_context.zip2.48 KB

Files was lost... re-attaching

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new flag_context-d6.patch5.87 KB

Re-roll with new line

mooffie’s picture

mooffie commented

Considering our experience with the Activity and Services integrations, it's probably not a good idea to add yet another "integration" to Flag.

We end up with mediocre code that nobody's here to maintain, upgrade and fix.

I'm in favor of "wontfixing" this.

Nate, what are your thoughts on this?

quicksketch’s picture

quicksketch
he/him
commented

I'm a big fan of Context module personally, but I'd have to agree that this integration seems slightly edgy and not very likely for me to use, even though I regularly use both Flag and Context. I don't think Flags are a likely system to use for setting contexts.

mooffie’s picture

mooffie commented

Andrey: As beautiful as your code is, it's not wise to bundle it with Flag. I think nothing's left now but to "wontfix" this.

mooffie’s picture

mooffie commented
Status: Needs review » Closed (won't fix)

Sorry.

doublejosh’s picture

doublejosh commented

Had two uses for Flag + Context to get away from more esoteric, less maintained modules.
Any interest in turning this into a stand alone connector module? ... for D7.

mwilbur’s picture

mwilbur
he/him
commented

I seriously encourage someone to take a look at this and open it back up. I also hope that people will realize just how powerful this could be integrated with context. Combine the two and you have a perfect way to control workflows and different sections of a site, plus endless other possibilities. Please, please, please, re-open, re-code and make Flags + Context a reality instead of a dream.

kourosh.a’s picture

kourosh.a commented

very interested in D7 version. Any luck?