Hi
I found that while i set in the flag options that user can't flag own comments, than the flag template is not loaded for comment authors. I think it is wrong, because other people like me can shown in the template number of flags and other info, so if the template is not loaded, comment author can't see how many users flag his comment and other info from the template.

My suggestion is to load the template always for everybody who have global flag permissions to see it, but put in the template some new access condition for shown flag link. Then I could still put some other code at front of this access condition or behind it, and shown it to comment authors.

Thanks for your great wor. On this module.
Igor

Comments

quicksketch’s picture

quicksketch
he/him
commented
Title: Template is not loaded » Load flag template even for users without access
Category: bug » feature

The problem here is that there is no "View access" at all on Flags, so there's no way to determine if a user should be shown a Flag if access is denied to them. The access system is a boolean hide or show, meaning that access denied because the user is the node author is the same as access denied because the user doesn't have the correct role. It sounds like in the first case this is when you'd want run through the template, but in the second you probably wouldn't (you shouldn't show anything about flags intended only for administrators).

In the mean time, you might consider making your own links through hook_link() in a module, or using the Flag APIs to retrieve the number of times an item has been flagged.

joachim’s picture

joachim commented
Category: feature » support
Status: Active » Fixed

> you might consider making your own links through hook_link() in a module, or using the Flag APIs to retrieve the number of times an item has been flagged.

Sounds like this has been addressed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.