#285237: Ability to disallow a flag/unflag operation is super cool, but we need to add tests to make sure that this functionality works correctly. We should test that access is both available and denied in the following situations:
- Flagging own content
- Flagging others' content
- Flagging own comments
- Flagging others' comments
- Flagging comments of own nodes
- Flagging comments of others' nodes
- In multiple and single access checks of all of the above
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | flag_comment_access_fix.patch | 671 bytes | quicksketch |
Comments
Comment #1
xn2001 commentedUsers may only flag own comments = OK
Users may only flag comments by others = OK
Users may only flag comments of nodes they own = Not OK
-Logging as node owner but there is no flag link in the comments. I expect flag links in the comments.
Users may only flag comments of nodes by others = Not OK
-Logging as node owner and there are flag links in the comments. It shouldn't.
-Logging as not the node owner and there are flag links in the comments. That is ok.
Comment #2
quicksketchThanks for testing these xn2001! I found a error in the access handling for comments like you described above. I've fixed it with the attached patch.
Note that this issue is actually for writing automated tests so this doesn't break in the future, so we'll leave this open even though the problem you described is fixed with this patch.
Comment #3
joachim commentedUpping the version.
The patch above fixes a bug that's not to do with this issue -- and the latest 6-2 branch has this fixed.
Comment #4
joachim commentedComment #5
joachim commentedWorth bearing in mind that #879988: Flag permission for 'own entities' will change how access to flag 'own' content will work, so might be best to postpone writing tests till that is in.
Comment #6
ivnishClosed as outdated because Drupal 7 is EOL