With view only permission to a node, it seems that node permissions affect batch node flag. Would it be possible to use flag permission since flagging a node doesn't neccessarily involve editing a node.
Joseph
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | flag_operations_behavior.patch | 802 bytes | quicksketch |
Comments
Comment #1
infojunkieThe problem is that node flagging is done via a node_operation, not an action. Node operations don't advertise whether they modify nodes or not, so in the spirit of security, VBO assumes that they do. In order to get around this, it would be necessary for third parties (e.g. the VBO admin) to inform VBO which node_operations are safe and which aren't. I'll consider this a feature request.
Comment #2
infojunkieAs a workaround, you can patch the declaration of
function flag_node_operations()in flag.module as the following:The
behaviorentry explicitly informs VBO that flag operations do not modify the node.Comment #3
jmolinas commentedive already patched the flag module by it does't seems to work
Comment #4
infojunkieTry clearing the cache. What doesn't work? What's the message that you get that indicates failure?
Comment #5
jmolinas commentedStill if the user dont have enough privilages, you cannot execute the flag operation (Not enough privilages)
Comment #6
infojunkieI've re-tested this patch successfully. Are you sure you don't have two versions of flag.module in your installation?
Comment #7
jmolinas commentedI'm using flags 6.x-1.1
Comment #8
infojunkieI meant look in your module folders to see if there aren't two copies of flags module.
If there's only one copy, please download the latest dev release of VBO and try again:
* Make sure the actions_permissions module is disabled.
* Does the bookmark action still appear in the operations list for non-admin users?
* If it does, try to execute the action. What is the exact error message that you get?
Comment #9
jmolinas commentedthank a lot!!! it works!!
Comment #10
infojunkieCan you let us know what you did to fix the problem?
Comment #11
jmolinas commentedcomment number 2 worked fom me
Comment #12
RoboPhred commentedChanging a module's code by hand can hardly be consitered "fixed".
Comment #13
quicksketchFixed with the attached patch. Committed to all versions of Flag.
Comment #14
quicksketchComment #15
infojunkieThanks quicksketch for taking the trouble to integrate with VBO!