Problem/Motivation
When you click on the flag or unflag link, a text appears for about 3 seconds. This text should last a little longer and be user-controllable.
Criterion 1.3.2 (Meaningful Sequence) and Criterion 4.1.3 (Status Messages): Dynamic changes in content must be appropriately announced; this is not met.
Steps to reproduce
Click on the flag or unflag link.
Proposed resolution
Make the message last longer and add a button so the user can close this text or message with JS.
Remaining tasks
Patch and review.
User interface changes
The message lasts longer and a button has been added so the user can close it.
API changes
N/A
Data model changes
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | After patch.mp4 | 512.68 KB | anjuelsaphilip2020 |
| #8 | Before patch.mp4 | 1.24 MB | anjuelsaphilip2020 |
Issue fork flag-3529190
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
jlozande commentedComment #3
ivnishComment #6
deaom commentedAdded additional field link duration that applies when ajax link type is selected, so the user has actual control on the duration of animation. That value then overrides the animation duration via JS. Updated test to now cover the added button (X). Needs review.
Comment #7
ivnishComment #8
anjuelsaphilip2020 commentedHi, I've verified and tested MR!168 and applied the patch successfully on 5.0.x-dev version. The changes are working as expected.
Following steps I followed:
Testing Result: After applying the patch, the status/confirmation message for Flag is working as expected.The message stays visible for the configured duration, and the close (X) button allows the user to dismiss it manually.
Attaching the video for reference.
Thanks
Comment #9
anjuelsaphilip2020 commented