Problem/Motivation

When upgrading to PHP 8.2 I get the error
Deprecated function: Creation of dynamic property flag_node::$weight is deprecated in flag_flag->construct() (line 223 of /home/nginx/www/miami/sites/all/modules/contrib/flag/includes/flag/flag_flag.inc).
Deprecated function: Creation of dynamic property flag_node::$show_as_field is deprecated in flag_flag->construct() (line 223 of /home/nginx/www/miami/sites/all/modules/contrib/flag/includes/flag/flag_flag.inc).
etc..

Steps to reproduce

Just have flag installed and on nodes it give this error on every node displayed

Proposed resolution

Change code?

CommentFileSizeAuthor
#3 flag-dynamic-property-deprecation-3359763-3.patch375 bytesmichelle

Comments

erald created an issue. See original summary.

erald’s picture

erald commented
Issue summary: View changes
michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Version: 7.x-3.9 » 7.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new flag-dynamic-property-deprecation-3359763-3.patch375 bytes

Because the properties that are being dynamically added aren't fixed and can be altered by other modules, defining them all is not possible. I added #[AllowDynamicProperties] to suppress the deprecation warnings.

illeace’s picture

illeace commented
Title: PHP 8.2 depreciated problem » PHP 8.2 deprecated problem

Fixing typo in issue name

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -deprecated +PHP 8.2

@Michelle Thanks, that seems appropriate to reduce the deprecation warnings from PHP 8.2