Although added as a field on the Flagging entity type, you get a fatal error if you actually try to use that field on a View whose base is Flagging. It only works when the Flagging is derived indirectly through a relationship.

CommentFileSizeAuthor
#2 flag-link-field-2886626-2.patch3.17 KBkevin.dutra

Comments

kevin.dutra created an issue. See original summary.

kevin.dutra’s picture

kevin.dutra commented
Assigned: kevin.dutra » Unassigned
Status: Active » Needs review
StatusFileSize
new flag-link-field-2886626-2.patch3.17 KB

Status: Needs review » Needs work

The last submitted patch, 2: flag-link-field-2886626-2.patch, failed testing. View results

kevin.dutra’s picture

kevin.dutra commented

Huh? That test passes for me locally, and I can't see any connection between a Views field plugin and the entity form... Attempting a retest.

kevin.dutra’s picture

kevin.dutra commented
Status: Needs work » Needs review
kevin.dutra’s picture

kevin.dutra commented

Not sure what the issue is with that failure, but I can't see any reason why this patch would have any effect. I confirmed again that it passes locally but the retest still failed. I don't know what else I can do to troubleshoot this, as there doesn't appear to be anything wrong with my patch.

joachim’s picture

joachim commented

Yeah, the Flag link field makes stupid assumptions about how it's used.

martin107’s picture

martin107 commented
Related issues: +#2895893: Restore/Convert ShowOnEntityFormTest to BrowserTestBase

Looks like the test failures are connected to a recently cleared branch blocker retestsing.

socketwench’s picture

socketwench commented
Status: Needs review » Fixed

Fixed! Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.