I just installed the latest -dev version of Flag and after I hit Save the page went blank.

[26-Jun-2008 18:32:40] PHP Fatal error:  Call to undefined function  db_num_rows() in /Applications/MAMP/htdocs/d6test/sites/all/modules/flag/flag.views_bookmark.inc on line 15

Comments

mooffie’s picture

mooffie commented
Category: support » bug

Yep, db_num_rows() doesn't exist in D6.

Nate, is it ok that I replace that code with `if (db_table_exists('views_bookmarks') {...}` ?

mooffie’s picture

mooffie commented
Priority: Normal » Critical
Status: Active » Fixed

OK, I fixed that. It was critical.

http://drupal.org/cvs?commit=123815
http://drupal.org/cvs?commit=123816
http://drupal.org/cvs?commit=123817

I made D5 and D6 the same code. BTW, the flag_views_bookmark_update_prepare() function didn't use {} around the table name so that was another bug squashed.

(Fayna, it takes several hours for a new 'dev' package to be repackaged.)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.