Eg:

   * @param AccountInterface $account
   *   Optional. The account of the user flagging the entity. If not given,
   *   the current user is used.

But should be like this:

   * @param mixed $timezone
   *   (optional) \DateTimeZone object, time zone string or NULL. NULL uses the
   *   default system time zone. Defaults to NULL.
CommentFileSizeAuthor
#1 2457067-optional-param-1.patch3.82 KBjoshi.rohit100

Comments

joshi.rohit100’s picture

Status: Active » Needs review
StatusFileSize
new3.82 KB

I couldn't find the param defination given in issue summary.

Status: Needs review » Needs work

The last submitted patch, 1: 2457067-optional-param-1.patch, failed testing.

joachim’s picture

Status: Needs work » Needs review

> I couldn't find the param defination given in issue summary.

If you mean the example I gave of a correctly-formatted param, then that was from core.

The incorrect one was from FlagService.

Our tests are fixed now, so let's retest this.

joachim’s picture

Status: Needs review » Fixed

The patch fixes all the occurrences.

Committed. Thanks for working on this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.