Closed (fixed)
Project:
Flag
Version:
8.x-4.x-dev
Component:
Documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Jan 2015 at 08:15 UTC
Updated:
18 Mar 2015 at 04:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
joachim commentedNeeds further work, as this looks wrong:
We're returning the result of AccessResult::allowedIf(), which according to https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Access!AccessResu... is a \Drupal\Core\Access\AccessResult.
Comment #2
martin107 commentedCurrent patch has been superseded a duplicate issue #2428981: FlaggingAccessController::checkFlag @param is out of step with code.
This is me just wearing a hair-shirt ... I should have spotted the return thing in that issue. :)
So starting with a new patch to just correct the return type.
The text looks fine as it stands.
Comment #3
socketwench commentedThat'd work for me.
Comment #6
socketwench commented