This has been bugging me for years ;)

Nowhere else in Drupal is there a boolean property whose name is formed like is_foo.

CommentFileSizeAuthor
#8 2412069-fixed-issue-for-2412069-8.patch4.01 KBnripeshtrivedi
#1 2412069-fixed-issue-for-2412069-1.patch3.66 KBnripeshtrivedi

Comments

nripeshtrivedi’s picture

nripeshtrivedi commented
StatusFileSize
new 2412069-fixed-issue-for-2412069-1.patch3.66 KB

Hi,

I am submitting a patch for this issue. Please review it

nripeshtrivedi’s picture

nripeshtrivedi commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: 2412069-fixed-issue-for-2412069-1.patch, failed testing.

Status: Needs work » Needs review

nripeshtrivedi queued 1: 2412069-fixed-issue-for-2412069-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: 2412069-fixed-issue-for-2412069-1.patch, failed testing.

nripeshtrivedi’s picture

nripeshtrivedi commented

If anybody could let me know why tests are failing in this patch can't figure it out

joachim’s picture

joachim commented

It looks like the test FlagSimpleTest.php needs changing to match the changed property name.

nripeshtrivedi’s picture

nripeshtrivedi commented
StatusFileSize
new 2412069-fixed-issue-for-2412069-8.patch4.01 KB

Thanks for the comment. Based on the same, I am submitting a patch, I hope it works

nripeshtrivedi’s picture

nripeshtrivedi commented
Status: Needs work » Needs review

  • nripeshtrivedi authored 000131d on 8.x-4.x 
    Issue #2412069 by nripeshtrivedi: Changed flag entity is_global property...
socketwench’s picture

socketwench commented
Status: Needs review » Fixed

Committed as 000131d. Thanks!!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.