rename flag id to flag name

updated 'id' to flag.

I tried to update the testcases for this as it seems like testcase problem to me.
I just tried with FlagConfirmFormTest but I am stuck with this :-

   // Click the flag link.
    $this->drupalGet('node/' . $node_id);
    $this->clickLink(t('Flag this item'));
  

I dont know if I am doing right. Can some one guide me in right direction ?

I'm reluctant to change it because when I look at NodeType.php...

<?php
class NodeType extends ConfigEntityBundleBase implements NodeTypeInterface {

  /**
   * The machine name of this node type.
   *
   * @var string
   *
   * @todo Rename to $id.
   */
  protected $type;
?>

That, combined with how "type" and "node" both seem more confusing to me than "id", I'm not inclined to change this.

+1 to using id and label and closing this as a won't fix :)

Core has been trying to go into that direction, just never reached it for all entity types, but a lot of them have been renamed.

And node type is probably the worst example that core has to offer, both with the double-meaning of type ($type->type? what exactly does $node->getType() return?) and using "name" for the label of a config entity.

It also seems to make more sense given we have an id() and label() methods on EntityInterface, it just seems to make more sense to leave the class variables as they are.