Closed (fixed)
Project:
Flag
Version:
8.x-4.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Jan 2015 at 15:29 UTC
Updated:
16 Feb 2015 at 22:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
joachim commentedLooking at core, long description texts in annotations aren't wrapped. This is a bit of a pain: #2409863: allow long text in annotations to be wrapped.
Until that's allowed, we need to unwrap the texts :/
Comment #2
joachim commentedTagging as novice.
Comment #3
nripeshtrivedi commentedHi,
I am not sure if this is correct since it voilates the 80 charaacter limit but still going by the description above. I am submitting a patch. Please review it
Comment #4
nripeshtrivedi commentedComment #6
nripeshtrivedi commentedI am not sure how the test is failing. Any help is appreciated
Comment #7
joachim commentedThe failing test isn't anything to do with this, as I get it locally too with HEAD -- something must have changed in core to break it.
Comment #8
joachim commented> I am not sure if this is correct since it voilates the 80 charaacter limit but still going by the description above
Indeed. There's no other way to do this -- core does the same with long description texts in annotations, I checked.
Thanks for the patch!
There's more than one of these though.
This regular expression will find them (if your text editor supports searching with regexps): description = "[^"]+$
(That's looking for an annotation line where the string doesn't have a closing quote BTW.)
Comment #9
nripeshtrivedi commentedThanks for the comments. I found out one more instance as pointed out. Pleas review the patch
Comment #10
nripeshtrivedi commentedComment #11
lokapujyaComment #12
nripeshtrivedi commentedIf you could let me know that the patch fixes the issue for this ?
Comment #14
lokapujyaThe tests were broken due to #2410773, but we fixed the tests already.
Comment #15
nripeshtrivedi commentedThanks for testing it again. Please let me know if you require anything on this patch further
Comment #16
joachim commentedCommitted. Thanks!