Hi,

I recently had a site and app wide security review. I thought I should report relevant finding here. I believe this probably would be hidden upon launch as we will not display issues, however, I guess it should be dealt with anyway.

Thanks,
Paul.
-
Information Leakage through Unhandled Error
Risk: LOW
DESCRIPTION
When the token parameter is missing in the Flag and Unflag functionality requests located at https://mydomain.me/flag/flag/follow/, an error message is display which leakes internal server routes.
IMPACT
This information can aid malicious users to perform their attacks.
EVIDENCE
https://mydomain.me/flag/flag/follow/174?destination=node/174
RECOMMENDATION
Handle the missing parameter error.

Comments

joachim’s picture

Version: 7.x-3.5 » 7.x-3.x-dev
Category: Support request » Bug report
Status: Active » Closed (works as designed)

First off, security issues should NOT be reported here! It does say that VERY LOUDLY at the top of the issue form!

At any rate, I don't actually think this is a security issue.

If I follow a link of the form /flag/unflag/my_flag/ID then I get redirected to the front page with these error messages:

    Notice: Undefined index: token in flag_page() (line 21 of /Users/joachim/Sites/workshop/sites/all/modules/contrib/flag/includes/flag.pages.inc).
    Bad token. You seem to have followed an invalid link.

That's because this flag is set to use the 'Normal link'. Hence a token is needed.

But the thing is -- the system will never output a URL of the form that would cause this error message in the first place! If your flag is set to the normal link, when any time you output a flag link, the token will be included.

Hence I'm closing this as 'works as designed' -- if you can demonstrate a way in which Flag outputs the link with the token missing, please reopen.

techypaul’s picture

Hi,

Agreed, it is not a security issue or I wouldn't have put it here (I did report other issues directly as required), apologies for not making that clear.

Re the actual issue: I will investigate and check if they just removed the token during testing, or if it was found somewhere, and obviously reopen as required.

Thanks for taking the time,
Paul.