Hi,

under certain circumstances, the unflagging of a node does not work in flag-6.x-1.3 from 2010-May-09 (usually, the 'flag' module is working fine for me). In the $links section of a flagged node is the usual "unflag" link (pointing to something like .../flag/unflag/network/15914?destination=node%2F15914&token=d307f0da217bd7bcd7fa9a003c763576); if I click on this "unflag" link as user #1, the node is not being unflagged.

The flag's configuration at ./admin/build/flags is pretty straight-forward: It's a flag for nodes, it's not global, exactly one role can use the flag, and it's active on exactly one content type. The flag link type is "JavaScript toggle". With Views, I can correctly list the flagged content, so the flagging itself appears to work correctly, only unflagging does not work.

Core/modules: Pressflow 6.22, Memcache 6.x-1.9, Path alias cache (from Pressflow), JavaScript Aggregator 6.x-1.6, CSS Gzip 6.x-1.3, jQuery UI 6.x-1.5, jQuery Update 6.x-2.0-alpha1, Block Cache Alter 6.x-1.4, Boost 6.x-1.x-dev.

At first I was suspecting an incompatibility with JS aggregation and switched the flag link type from "JavaScript toggle" to "normal link". However, this didn't resolve the problem. I don't know if this issue has been fixed in recent dev releases, but since 6.x-1.3 is still tagged as "recommended", I'm reporting it. Please advise how I should continue.

Thanks you!

Comments

quicksketch’s picture

quicksketch
he/him
commented

Does this happen with all content on the site? Could you try flagging something that's not flagged at all and see if you can then unflag it? You may be experiencing #1097582: Flags become pseudo orphaned when switching existing flag to global.

asb’s picture

asb commented

Thanks for the quick reply! I'll try to describe the 'flag' behaviour more in detail.

  • The "broken" flag is used on a content type "Ressource"; it is also enabled for two other flags; both do work on nodes of this content type; so probably it's not specific to a content type;
  • NID 21158 is a node of content type "Ressource", but not flagged with the "broken" flag; flagging and unflagging the node with the "broken" flag does work;
  • NID 21171 is another node of content type "Ressource", but it was flagged with the "broken" flag about a year ago; unflagging the node with the "broken" flag does not work;
  • I'm experiencing the described behaviour on two different sites (different codebase, but similar configuration and both on Pressflow 6.22); so it's not specific to one site

It appears as if the "broken" flag has become somehow "stale" on certain nodesas it was flagged (and not changed since then) several months ago.

quicksketch’s picture

quicksketch
he/him
commented

The issue in #1097582: Flags become pseudo orphaned when switching existing flag to global reflects a situation in which this can become possible. If the flag used to be global and is not global any more (or vice-versa), all of the flaggings that were made before the change may still be affecting the site. You should check in your database to see if you have unexpected records in the flag_content table in your database.

If the flag is currently global, but the UID should be 0 for all items.
If the flag is not global, there should be no items that have a UID of 0.

asb’s picture

asb commented
Version: 6.x-1.3 » 7.x-2.0-beta6
Status: Active » Closed (fixed)

Updated to flag-6.x-2.0-beta6, ran update.php, reloaded the node(s). Now everything appears to work as advertised. Freaky, but fixed for me, closing issue.

klucid’s picture

klucid commented

Good call. This was my issue. Thanks!