hey
1. Flags exported as Features are added to the DB. can they live only in code, like other exports do?
2. when you change a Flag that was added to a Feature, you can't revert back to the default code. missing UI link at /admin/build/flags. also, a bug? #1117502: Flags in code can't be reverted to code
3. when you disable a Feature that adds Flags, the flags remain in the DB (see 1.). they don't get deleted. see #1272336: Disabling features should delete flags in default state automaticaly
4. you should not be able to delete a Flag that was added by a Feature, as they should live in code (see 1).
5. store and export Roles with their names (or machine names provided with UUID), not IDs: #1204918: Export roles as names rather than IDs
http://drupal.org/project/uuid
http://drupal.org/project/uuid_features
Comments
Comment #0.0
lpalgarvio commentedmore stuff
Comment #1
quicksketchThese all should be separate issues. Regarding 1-3:
No, because Flags have abilities that other exports do not. Views, Panels, ImageCache presets and other things only have a concept of "overridden" and "default", but no concept of certain properties being "locked" while others may be edited by administrators. This is intentional functionality of the Flag module so that you can lock things like the flag name and link type, but allow administrators to change the link text or confirmation messages. That way other modules can ship with default flags that they can depend on certain functionality.
Let's leave that to the other issue.
That sounds like a bug, let's make a dedicated issue for it.
You can't actually delete a flag added by a feature, "deleting" it will merely reset it back to the defaults (afaik).
Let's leave that to the other issue.
Making a big "multi-issue" like this doesn't help actually solve the problems, since we're not going to try to track 5 different problems in a single issue. Combining issues makes tracking the changes more difficult. If there isn't already and issue for #3, please file a new issue. All other problems already have individual issues or are intentional behavior.
Comment #1.0
lpalgarvio commentedsome more
Comment #2
lpalgarvio commentedi'm aware, i was just trying to sum up what's wrong in the integration. some of these issues might be related in problem, cause or solution :)
regarding #3: new issue at #1272336: Disabling features should delete flags in default state automaticaly
regarding #4: if your explanation is fully true, would it be possible to replace the delete with a revert button?
Comment #2.0
lpalgarvio commentedminor change