Flag 2.x expects a second parameter, sid, to get_user_count(). Flag 1.x doesn't. This makes it harder for me to write snippets to users that should work on both systems. Moreover, calling flag_get_sid() looks "out of place" in such snippets, even if they're for Flag 2.x only.

We should make the 'sid' optional.

Comments

mooffie’s picture

mooffie commented

Here's one example for the tedious discussions I have to conduct with users because of this. Not to mention all the handbook pages that will have to be updated.

mooffie’s picture

mooffie commented
Status: Active » Fixed

Fixed.
http://drupal.org/cvs?commit=473368
http://drupal.org/cvs?commit=473372

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.