Support For Other Content Type Settings (Fivestar Extra Module)

The Fivestar Extra module allows Fivestar rating of comments and users. It was made possible by the support of quicksketch, making certain changes to Fivestar that I needed. I'm grateful for that.

If the content type being rated is not a node, however, Fivestar uses hard-coded defaults in certain places. In particular, the number of stars is always returned as 5.

This causes some bugs in Fivestar Extra.

I'm requesting a way to override these defaults for other content types.

quicksketch:

Seems like we could use a generic "fivestar_get_settings($content_type, $content_id)" function that pulls in settings for a particular content type/id combination.

Previous discussions touching this issue:

http://drupal.org/node/280735#comment-1070105
http://drupal.org/node/317317#comment-1540114
http://drupal.org/node/326436#comment-1539122

Fivestar functions affected:

fivestar_vote() (line 259)
fivestar_static() (line 729)

Suggestion

I realise you have a lot of things to consider when you make structural changes to this module. This is just my 2 pence:

Perhaps a $fivestar_settings array is fetched by these functions, and that, when fetched, drupal_alter() is called on it with the $content_type and $content_id?