I realize webform tokens is a side issue to this module, but it appears to be supported here. Thanks for maintaining them also. I've found a bug with webform 3.x and the date token. No date value get inserted in the form. It appears that all the other tokens work fine. There must be some change in the date component in webform 3.x.
Thanks again, Dave

CommentFileSizeAuthor
#3 webform_tokens.patch685 bytesmecmartini
#2 webform_tokens.patch966 bytesmecmartini

Comments

dabro’s picture

dabro commented
Category: task » feature

Change to feature request

mecmartini’s picture

mecmartini commented
Status: Active » Needs review
StatusFileSize
new webform_tokens.patch966 bytes

I made the following patch to make date tokens work with webform 3.x.

mecmartini’s picture

mecmartini commented
StatusFileSize
new webform_tokens.patch685 bytes

Sorry, I forgot to remove some test code.

Here the clean patch.

dabro’s picture

dabro commented

Thanks for the patches, I can confirm that it did fix the date tokens in webform 3. Sorry for the slow response, just tested the patches the other day. The patch would appear to break webform 2 date tokens, I assume. Dave

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Assigned: Unassigned » wizonesolutions

I'll apply and test this patch soon. I'm able to check which Webform version is being used and adapt accordingly. What I will probably do is finish the Webform Tokens module and make the module prefer that, though I will leave the existing file in there at least for the next official release. People will need to install Webform Tokens if they want them for Webform 3.x tokens. I will remove the file altogether in a future release and definitely if I ever start a new branch.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Needs work

Actually, I fixed this in Webform Tokens (used with 7.x). I will apply the same fix to this issue soon and provide a new patch.

Solthun’s picture

Solthun commented

Hello! Any progress on this issue? The patch works great, thank you ghostdog, but it would be great if it were part of the module or if it would have tokens for different date formats.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Ah, I have to roll a new patch for 6.x. If you provide one, I'll test it. Otherwise, I will try to get to this within the next few weeks.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs work » Active
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Assigned: wizonesolutions » Unassigned

Patch still needed for this, to be done when I look at 6.x issues.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Active » Fixed

macMartini's patch worked fine and has been committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.