The current way of passing webforms to a FillPDF Link requires a cumbersome workaround in Views to avoid [nid] and [sid] being interpreted as Views replacement patterns.

A very simple fix would be to change these to webform_nid and webform_sid in 7.x-2.x-dev since it's the development version. It would be a breaking change, so it would probably be best to deprecate the old way (log a watchdog entry every time they do it) and then remove it in 7.x-3.x-dev. Since people are probably using it and no one reads release notes.

Comments

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 7.x-2.x-dev » 8.x-4.x-dev
pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Assigned: Unassigned » wizonesolutions

Mostly, this would be v5 stuff. However, if we want to make this change in 8.x-5.x and 7.x-3.x, our current branches should at least allow that new notation, meaning it should understand links in this notation.

Is this still the way we want to go? Alternatives would be:

  1. &webform=nid&webform_submission=sid
  2. &webform_submission=nid:sid

or possibly both variants.

Assigning to @wizonesolutions for feedback.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Assigned: wizonesolutions » Unassigned
Status: Active » Postponed

I'm re-reading this, and I'm not sure anymore. Let's postpone this and focus on non-link ways of filling in PDFs. For example, we could have a View display that generates a PDF from Webform submissions when visited. Through Views contextual arguments, it could step around the entire issue.