Closed (fixed)
Project:
filedepot
Version:
6.x-1.0-rc4
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
19 Aug 2010 at 06:09 UTC
Updated:
27 May 2014 at 15:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
blainelang commentedUsers need to have view access to the folder which contains the files you have tagged via role or group. Access to view tags is only maintained at the role or group level. We do not want to show a tag like 'company reorg' to users that don't have view access to such tagged files.
Comment #2
xraiveToronto commentedI am having a similar issue with the Tags. Currently all users can view all tags regardless of what folders they have access too.
Comment #3
bibstha1 commentedSubscribing
Comment #4
blainelang commentedI have confirmed there is a bug with the tag cloud under this situation:
- folders have several roles or groups assigned
- files added or tags added to files
- filedepot creates the tag cloud records with references for each role or group so users with these permissions will see the tags
- folder access permissions are updated and one or more role or group access is removed
- the tagcloud record are not updated
It will be necessary to update the tagcloud records for every file in the updated folder for which tag words have been assigned.
The reverse situation as well will need to be considered. If you assign tags to files and then add a role or group permission, then new tagcloud records will need to be created.
I am working on a patch but need more time and wanted to provide an update.
Comment #5
blainelang commentedAttached is a patch that will now add/remove access records for the tagwords as permissions are changed for folders. The patch includes a SQL update - to add a new serial field 'id' to the nextag_metrics table.
Patch was build against version 1 release.
Comment #6
blainelang commentedComment #7
bibstha1 commentedHi blainelang, can you briefly explain how tags work?
You mentioned that the tags are implemented only in roles or groups level. How does it work in simple scenario? Example,
a. RoleManager
FolderA permissions
- can admin, view, upload, ..
b.RoleViewer
FolderA permissions
- can view
So any file in FolderA is accessible to both RoleManager and RoleViewer right? The tags will be visible under the file listing to both roles as well.
Now if RoleManager uploads a file and tags "VIP", "IMP", "TODO", will RoleViewer be able to see these by clicking on "Tags" link besides the top search?
Comment #8
bibstha1 commentedOne observation from of the patch.
a. User has upload permission to folder DirA and DirB
b. User uploads file in DirA, marks TagA, TagB, TagC
c. User uploads file in DirB, marks TagC and Tagd
d. Permission of DirB is changed so user is no longer given view access.
e. User has access to TagA and TagB only, no TagC access but his file in DirA with TagC is still there.
Comment #9
blainelang commentedI have just re-tested the v1.0 and found several issues with tags and folder permission - tag related records that allow the display for the individual tag cloud view was not working correctly, when folder perms for a user were added and then removed, or a new role.group added to an existing folder - the associated tags for the files in that folder were not added so the new users would see the new tags.
Changes are now in the CVS - once the nightly download is created.