The filedepot toolbar has lost its formatting. The specific issue that I have looked at is that the element id of both the New Folder and New File links in the toolbar have been changed BUT the javascript responsible for implementing the YUI interface has not been updated.

Here is an extract from 'filedepot-mainpage.tpl.php' (line 114) followed by an extract from 'initapplication.js' (line 178). If I edit the ids filedepot_newfolder_link and filedepot_newfile_link to newfolderlink and newfilelink respectively, then the YUI buttons return.

In addition to this issue, the height of the toolbar has been fixed via css to 25px yet the height of elements contained within it are governed by css styles beyond the control of this module and so elements will push out of the bottom of the bar. I have attached a screenshot to illustrate these points.

<div style="float:left;width:250px;height:20px;padding-left:20px;">
      <?php if ($show_newfolder == 'true') { ?>
        <span id="filedepot_newfolder_link">
          <span class="first-child">
            <a class="ctools-use-modal ctools-modal-filedepot-newfolder-dialog-style" href="<?php print url('filedepot/nojs/newfolder'); ?>">New Folder</a>
          </span>
        </span>
      <?php } ?>
      <?php if ($show_upload == 'true') { ?>
        <span id="filedepot_newfile_link">
          <span class="first-child">
            <a class="ctools-use-modal ctools-modal-filedepot-newfile-dialog-style" href="<?php print url('filedepot/nojs/newfile'); ?>">New File</a>
          </span>
        </span>
      <?php } ?>
      </div>
try {
    if (show_newfolder) {
      Dom.setStyle('newfolderlink','display','');
      var oLinkButton1 = new YAHOO.widget.Button("newfolderlink");
      Event.addListener("newfolderlink", "click", showAddCategoryPanel, YAHOO.container.newfolderdialog, true);
    }
  } catch(e) {}

Comments

_timpatrick’s picture

Assigned: Unassigned » _timpatrick

It sounds like the theme you are using is overriding it - what theme do you have installed?

_timpatrick’s picture

Status: Active » Postponed (maintainer needs more info)
simonp98’s picture

Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new52.4 KB
new45.27 KB
new45.73 KB
new57.44 KB

Apologies for the late reply ...

I am using a custom theme BUT I have also made a clean install and tried various themes all with the same issue. I have attached screen shots of Bartik, Seven, Garland and my own theme. All display this issue. I think is problem is in the code extracts in my original post. The YUI call to setStyle uses an ID that just doesn't exist in the original tpl files.

_timpatrick’s picture

Status: Active » Fixed

Thanks! Made the changes and it fixed it. I applied the changes to dev so it should be available in the dev release tomorrow when it gets rebuilt.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit b60a52d on 7.x-1.x, 8.x-1.x by _timpatrick:
    Issue #1928286 by simonp98 - YUI button fix