While running PHPCS we get the below warning.

FILE: ...modules/contrib/filebrowser/src/File/DisplayFile.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
102 | WARNING | Method name "DisplayFile::__constructor" is discouraged; PHP
| | has reserved all method names with a double underscore prefix
| | for future use.
--------------------------------------------------------------------------------

CommentFileSizeAuthor
#3 PHP7.2_Compatiability-3080768-3.patch359 bytessmrutha

Comments

smrutha created an issue. See original summary.

smrutha’s picture

smrutha commented
Version: 8.x-2.x-dev » 8.x-2.0
smrutha’s picture

smrutha commented
StatusFileSize
new PHP7.2_Compatiability-3080768-3.patch359 bytes

The solution for the above is:

smrutha’s picture

smrutha commented
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: -PHP 7.2 compatibility +PHP 7.2

  • clivesj committed 0e8f55b on 8.x-2.x 
    Issue #3080768 by smrutha: PHP 7.2: Method name DisplayFile::...
clivesj’s picture

clivesj commented
Status: Needs review » Fixed

  • clivesj committed 6a26011 on 8.x-2.x 
    Issue #3080768 by clivesj: PHP 7.2: Method name DisplayFile::...
clivesj’s picture

clivesj commented
Status: Fixed » Active

rioll back

  • clivesj committed 2f60aaf on 8.x-2.x 
    Issue #3080768 by clivesj: PHP 7.2: Method name DisplayFile::...
clivesj’s picture

clivesj commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.