Need to fix file.admin-content-file.inc to match the approach taken to fix the security issue in Admin Views.

The new version of Admin Views will automatically update any view with menu as the access type, but the code in the default File Entity view still needs to be updated:

$handler->display->display_options['access']['type'] = 'menu';

Should be changed to this:

$handler->display->display_options['access']['type'] = 'perm';
$handler->display->display_options['access']['perm'] = 'access administration pages';

See attached. Not sure if you'd prefer the default permission to be "administer files" instead of "access administration pages".

Comments

ron_s created an issue. See original summary.

sgdev’s picture

Also should mention admin_views 7.x-1.7 does update the default File Entity admin_view if one exists, and sets the perm to access administration pages.

However, this patch will fix the situation where someone installs admin_views 7.x-1.7, applies admin_views_update_7100, and then later on installs File Entity with the improper permission.

damienmckenna’s picture

drumm’s picture

Status: Needs review » Closed (duplicate)

Publishing since this was handled with #3095763: Better default permissions for views pages based on file entity admin page

Please report potential security issues confidentially in the future.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.