• file_entity_file_update() saves metadata, then deletes metadata, then saves metadata again. (lines 101-115)
  • conditional on line 120 will never evaluate to true
  • conditional on line 120 does not account for empty `$file->metadata` generating php notices for invalid index

http://cgit.drupalcode.org/file_entity/commit/file_entity.file.inc?id=03...

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Parent issue: » #2130921: Improvements to file_entity_file_insert/update functions

This was resolved with #2130921: Improvements to file_entity_file_insert/update functions

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Closed (duplicate)