This is one way to solve problems with exporting file types, is to ensure that all the information for a file type is contained in our one table. I'm wondering why exactly we'd need three separate tables to store file types, when it might be complicating things.

Related:
#1845516: Custom file types exported through Features are missing mimetype information.
#1979832: Remove schemes from file types

CommentFileSizeAuthor
#8 merge-mimetype-information-into-file-type-1977708-5.patch5.51 KBvenugopp
#4 merge-mimetype-information-into-file-type-1977708-4.patch5.47 KBdevin carlson
#4 exportable_mimetypes.png63.6 KBdevin carlson

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

This would also fix that file_entity_uninstall() needs to use API functions to load the file types.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Note that #1979832: Remove schemes from file types would remove the file_type_streams table.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Merge the file_type_mimetypes and file_type_streams into serialized fields on the file_type table » Merge file_type_mimetypes into a serialized field on the file_type table

Reducing scope now that #1979832: Remove schemes from file types is committed.

devin carlson’s picture

devin carlson commented
Assigned: dave reid » devin carlson
Status: Active » Needs review
StatusFileSize
new exportable_mimetypes.png63.6 KB
new merge-mimetype-information-into-file-type-1977708-4.patch5.47 KB

A patch to store mimetypes in the {file_type} table as a serialized blob.

It includes an update function to migrate existing MIME types from {file_type_mimetypes} into {file_type}.

A screenshot showing that MIME type information is now exportable with Features!

exportable_mimetypes.png

devin carlson’s picture

devin carlson commented

Marked #1845516: Custom file types exported through Features are missing mimetype information. as a duplicate.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Tested #4 with a number of existing sites and didn't run into any upgrade path problems (only default file types, additional custom file types, file types with default/additional/no MIME types).

Committed to 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

venugopp’s picture

venugopp commented
Status: Closed (fixed) » Fixed
StatusFileSize
new merge-mimetype-information-into-file-type-1977708-5.patch5.51 KB

With the above patch, it overwrites the default mimetypes.
It should migrate only the customised mimetypes.

Here is the patch for this.

aaron’s picture

aaron commented
Status: Fixed » Needs review
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

@pradeepvenugopal: That patch doesn't look correct. Can you make sure it's rolled against the very latest 7.x-2.x branch in Git?

venugopp’s picture

venugopp commented
Status: Needs work » Closed (duplicate)

The fix is already available in the latest branch.

venugopp’s picture

venugopp commented
Issue summary: View changes

Adding http://drupal.org/node/1979832 to related issues