Problem/Motivation

The change merged in #3589931: Fatal error: Markup::settingsForm() signature must be compatible with FieldGroupFormatterBase updated a function signature to work with Field Group 4.1.x (currently alpha). That change breaks compatibility with Field Group 4.0.x—the stable, recommended release.

Using Field Group Markup 1.0.4 with Field Group 4.0.0 yields the same/similar message as the other issue:

Fatal error: Declaration of Drupal\field_group_markup\Plugin\field_group\FieldGroupFormatter\Markup::settingsForm(array $form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\field_group\FieldGroupFormatterBase::settingsForm() in /var/www/html/docroot/modules/contrib/field_group_markup/src/Plugin/field_group/FieldGroupFormatter/Markup.php on line 64

Steps to reproduce

  1. On a site using Field Group 4.0.0, update Field Group Markup to 1.0.4
  2. Visit any form with a Field Group Markup field OR
    Visit the Manage Form Display for an entity and attempt to add a Field Group Markup field
  3. Observe the error above

Proposed resolution

Something like:

CommentFileSizeAuthor
#4 3612052-04.patch645 bytesayrmax

Issue fork field_group_markup-3612052

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

justcaldwell created an issue. See original summary.

justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
commented
Status: Active » Needs review

Setting to Needs Review, as this is more about branch/tag changes than code updates.

seanb made their first commit to this issue’s fork.

ayrmax’s picture

ayrmax commented
StatusFileSize
new 3612052-04.patch645 bytes

I have created a patch to fix the issue.

  • dieuwe committed 674584a3 on 1.0.x 
    Issue #3612052: Restore Field Group 4.0.x and 8.x-3.x compatibility
dieuwe’s picture

dieuwe
Location Auckland, NZ
commented

I've gone with a variation of the proposed solution to try and keep 4.0 and 4.1 support in one branch - this module is simple enough to be able to support all major field_group version, I hope.

New release will come when some test coverage to avoid regressions like this is ready.

dieuwe’s picture

dieuwe
Location Auckland, NZ
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.