Closed (fixed)
Project:
Field Group
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2010 at 13:58 UTC
Updated:
2 Dec 2012 at 14:05 UTC
Jump to comment: Most recent file
Comments
Comment #1
Stalski commentedok, sorry for that ;)
fixed and committed
Comment #2
andypostThere's security issue with this fix http://drupal.org/cvs?commit=468534
User input printed without validation!!!
Comment #3
nils.destoop commented$group->label now goes to check_plain.
Comment #4
andypostSuppose this should be check_plain(t($group->label)) and another missed place with direct output
Comment #5
andypostUsing %group is enough for check_plain()
Comment #6
nils.destoop commentedPatch applied
Comment #7
andypostThis hunk is lost before commit!!!
Also I'd like to point that core does not translate a strings that are user defined - this task for l18n module
Powered by Dreditor.
Comment #8
nils.destoop commentedSecond line of patch also committed.
Thx for the Dreditor link. Didn't know that one. Very usefull for small patches.
Hope Chrome support works fast. :)
Comment #9
Stalski commentedNice job ;)
Comment #10
carajito commentedThis will be incorporated into the next update?
Comment #11
nils.destoop commentedThis is on dev. So it will idd be incorporated into the next update.
Comment #12
carajito commentedan estimated date???
Comment #13
carajito commentedIt is not on the 7.x - 2.x-dev yet
Comment #14
adelka commentedsubscribe - solution for 7?