I'm using Feeds along with the SelfNodeProcessor plugin and it won't work because feed imports are automatically suppressed for feed_source targets.
Specifically, this line in FeedsNodeProcessor.inc

$target_node->feeds['suppress_import'] = TRUE;

When the line's commented out, everything works perfectly.
Is there any reason this code is there?

CommentFileSizeAuthor
#9 feeds_selfnode_processor-import_on_create-2347393-9.patch7.21 KBtwistor
#6 feeds_selfnode_processor-import_on_create-2347393-6.patch2.43 KBtwistor

Comments

berimbolo’s picture

berimbolo commented
Issue summary: View changes
twistor’s picture

twistor commented
Status: Active » Closed (works as designed)

Yup, that's supposed to be there.

The problem is that if you're importing 1000 feed nodes, then each of the 1000 feeds will start importing as well.

berimbolo’s picture

berimbolo commented

But if the original feed node content never changes then those derivative nodes will never be triggered to self import, no? (Apologies if my terminology is a little off, hopefully you get what I'm trying to say)
Would it be possible to have 'suppress_import' as a config option rather than hard coded?

twistor’s picture

twistor commented

Well, they should still import via cron. We could do some sort of workaround in feeds_selfnode_processor. See you over in the queue.

twistor’s picture

twistor commented
Title: Imports suppressed for feeds_source targets » Bypass suppress_import.
Project: Feeds » Feeds Self Node Processor
Version: 7.x-2.x-dev » 7.x-1.x-dev
Category: Bug report » Feature request
Status: Closed (works as designed) » Active

Errr... Moving.

twistor’s picture

twistor commented
Status: Active » Needs review
StatusFileSize
new feeds_selfnode_processor-import_on_create-2347393-6.patch2.43 KB

This adds a new option of the processor settings page that allows imports to proceed on creation.

twistor’s picture

twistor commented
Issue tags: +Needs tests

Need a test for this.

berimbolo’s picture

berimbolo commented

Wow! That was really fast turnaround!
Really appreciate your effort.

twistor’s picture

twistor commented
Issue tags: -Needs tests
StatusFileSize
new feeds_selfnode_processor-import_on_create-2347393-9.patch7.21 KB

With tests.

I've run into this issue before. Running cron repeatedly is no fun.

  • twistor committed 4ad2861 on 7.x-1.x 
    Issue #2347393 by twistor | berimbolo: Added Bypass suppress_import.
twistor’s picture

twistor commented
Status: Needs review » Fixed
berimbolo’s picture

berimbolo commented
Status: Fixed » Reviewed & tested by the community
twistor’s picture

twistor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.