With Drupal's entity API we can consolidate process() and clear() methods into FeedsProcessor having specific entity processors only declare CRUD methods for entities and a little extra.

The benefit of doing this is that we consolidate processor level features and that we further consolidate processor level features like batching, replace/update existing etc.

Patch coming.

CommentFileSizeAuthor
#2 932772-2_consolidate_processors.patch60 KBalex_b
#1 932772-1_consolidate_processors.patch38.06 KBalex_b

Comments

alex_b’s picture

alex_b commented
Status: Active » Needs review
StatusFileSize
new 932772-1_consolidate_processors.patch38.06 KB

This consolidates processors.

The main difference is that process() and clear() are now implemented by FeedsProcessor. This means that FeedsNodeProcessor, FeedsTermProcessor and FeedsUserProcessor do not need to implement process() or clear() (of course they are still free to do so).

The entity handling (creating, loading, saving, deleting nodes, terms, users) is handled by a very thin abstraction layer - basically a set of methods (entityLoad() entitySave() etc.) implemented by node, term, user processors.

This patch consolidates the update/skip settings into the processor and it brings item hashing (skip items that haven't changed), batched user creation and user deletion (also batched) for free.

alex_b’s picture

alex_b commented
StatusFileSize
new 932772-2_consolidate_processors.patch60 KB

All tests passing.

alex_b’s picture

alex_b commented
Title: FeedsProcesssor: Consolidate process() and clear() » FeedsProcessor: Consolidate process() and clear()
alex_b’s picture

alex_b commented
Status: Needs review » Fixed

All tests passing. This is committed now.

http://drupal.org/cvs?commit=432318

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tassaf’s picture

tassaf commented

How to import data into database table .. not entity