Now the whole batch stops when something goes wrong with particular mapping.
I think it's much better to process the whole queue not saving nodes with problems while showing warnings.
I modified FeedsNodeProcessor.inc to catch exceptions in $this->map() and perform node_save() + update stats only if there was no exception.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | FeedsNodeProcessor.inc-755544.patch | 1.63 KB | Monkey Master |
| #3 | FeedsNodeProcessor.inc-755544.patch | 1.54 KB | Monkey Master |
| #1 | FeedsNodeProcessor.inc-755544.patch | 1.56 KB | Monkey Master |
Comments
Comment #1
Monkey Master commentedComment #2
alex_b commentedAgreed.
1. You can put
$this->map($item, $node);andnode_save()into the same try{} block to avoid the unelegant $save_node toggle.2. Could you add a watchdog() call next to the drupal_set_message() ?
Patch against head please! Thank you!
Comment #3
Monkey Master commenteddone.
I'm actually new to CVS and use TortoiseCVS (win32). I thought I use HEAD already...
Comment #4
alex_b commentedI see - on Windows I've found working from the command line with cygwin to work best. BTW, patches should be rolled from the module's base directory (or if against Drupal itself, from the site's root directory). (Not directly related but a common issue: If you need to add a new file and don't have write access to CVS, you can use cvsdo for it). See Creating patches for more guidelines.
Needs review.
Comment #5
alex_b commentedDoes not apply to latest head, please reroll. General approach looking good.
Comment #6
Monkey Master commentedI made this patch with command-line win32 CVS utility, hope it's ok
Comment #7
alex_b commentedComment #8
alex_b commentedThis is committed now, thank you.
http://drupal.org/cvs?commit=367696