Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The current code of the module produces a lot of "unsafe usage of new static()" warnings from phpstan, which are silenced in the phpstan.neon file but show up when using Upgrade Status to check for Drupal 12 compatibility. Now that autowiring is available in core, there is less reason to ignore this warning.
Steps to reproduce
On a Drupal 11 site, use Upgrade Status module to scan Feeds module.
Proposed resolution
Use autowiring of dependencies when possible so that the create() method is not necessary, or rewrite create() so that it does not return a new static.
Remaining tasks
make an MR.
Issue fork feeds-3591423
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
benstallings commented