In Drupal core 8.9.0, the Zend components have been replaced by Laminas.

This means instances of:

use Zend\Feed\Reader\Reader;
use Zend\Feed\Reader\FeedSet;
use Zend\Feed\Reader\Extension\AbstractEntry;
use Zend\Feed\Reader\Exception\ExceptionInterface;
use Zend\Feed\Reader\StandaloneExtensionManager;

should be replaced with:

use Laminas\Feed\Reader\Reader;
use Laminas\Feed\Reader\FeedSet;
use Laminas\Feed\Reader\Extension\AbstractEntry;
use Laminas\Feed\Reader\Exception\ExceptionInterface;
use Laminas\Feed\Reader\StandaloneExtensionManager;

Classes affected:

Drupal\feeds\Feeds\Parser\SyndicationParser
Drupal\feeds\Utility\Feed
Drupal\feeds\Zend\Extension\Georss\Entry
Drupal\Tests\feeds\Unit\Feeds\Parser\SyndicationParserTest

The majority of the fixes would be just to replace the use statements, however Georss Entry class and tests classes might also need to be renamed/moved. Not entirely sure. I also suppose that the core_version_requirement would need to be bumped from ^8.8 to ^8.9 in feeds.info.yml

See the CR here: https://www.drupal.org/node/3104895

Issue fork feeds-3152178

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jwilson3 created an issue. See original summary.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Issue summary: View changes
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Postponed

Yes, I kinda wondered that this should be changed at some point. But I find it too early to bump the requirement to Drupal 8.9. So maybe change this when Drupal 8.8 is no longer supported - or maybe when Drupal 8 support ends. There’s no hurry to change this as the current code still works with Drupal 9.

SpadXIII made their first commit to this issue’s fork.

SpadXIII opened merge request !29

spadxiii’s picture

spadxiii commented

Added an MR that changes the namespace of the class to Laminas. Kept the old class in there with a @deprecated-comment.

spadxiii’s picture

spadxiii commented
Status: Postponed » Needs review

  • MegaChriz committed 0a55472 on 8.x-3.x authored by SpadXIII 
    Issue #3152178 by SpadXIII, MegaChriz, jwilson3: Replaced Zend framework...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Thanks SpadXIII! I noticed that several errors occurred with Feeds on Drupal 9.3.x and this change fixed these. Apparently the compatibility layer has been removed now. Probably happened by accident in #3236249: Update dependencies for 9.3.x? This does mean we need to bump the minimum supported version to Drupal 8.9, but I think that that is fine at this point.

Merged!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

On November, 2021, Drupal 8.9.x won't be supported anymore. Right now, only security issue are fixed, for Drupal 8.9.x.

megachriz’s picture

megachriz
Primary language Dutch
commented

@apaderno
Yeah, I know. But I think that with Feeds I will support Drupal 8.9 a few months longer because there are still a lot of D8 modules that have not been made compatible for D9 yet. Feeds is also used by a client of mine and I think we won't get their site to D9 in time (before November 2, 2021, that is).

I think I might drop D8 support when the first alpha of Drupal 10 gets released. Because there are some deprecations to be fixed that in theory could make the module incompatible with D8. I haven't looked into the details of these deprecations yet.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.