Currently the submit button on the import form is just in the root of the form, which makes it hard to add form elements above the buttons.

It would be best to use the form API actions wrapper so they get put at the bottom.

CommentFileSizeAuthor
#2 feeds-import_form_actions-2939042-2.patch982 bytesrooby

Comments

rooby created an issue. See original summary.

rooby’s picture

rooby commented
Status: Active » Needs review
StatusFileSize
new feeds-import_form_actions-2939042-2.patch982 bytes

Here's the patch.

  • MegaChriz committed 463f559 on 7.x-2.x authored by rooby 
    Issue #2939042 by rooby: Use actions wrapper for buttons on standalone...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Good idea. I searched for $form['submit'] in the code base to check if there were any other changes needed. $form['submit'] does appear in other places, but belong to other forms. I also checked the import form manually, both in the default state - when the import button can be clicked - as in the state where an import is in progress.

The change could in theory break other modules that now alter $form['submit'] for the standalone import form, but I'm willing to take the risk that these modules need to be updated.

Committed #2.

rooby’s picture

rooby commented

Thanks. Yeah, aside form the other module's form alters issue I also didn't see any unexpected side-effects in my testing.

rooby’s picture

rooby commented

Since there is that possibility of breaking form alterations, I have added a draft change notice: https://www.drupal.org/node/2939316

megachriz’s picture

megachriz
Primary language Dutch
commented

Thanks for writing the change record. I added to the change record that the change only affects the standalone import form. There is an other import form used on feed nodes (when the importer is attached to a content type).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.