InvalidArgumentException thrown when saving a download feed with no URL

Attaching a patch that both makes the source field required and handles the exception thrown by the translateSchemes function. I'm not sure if the source needs to be required if we are handling the exception, and I'm not sure if the exception should kill the save, but barring a good reason not to make the changes I think this is a good idea.

Tested out the updated patch and it looks good on my end, with the exception of the webcal[s] validation you mentioned. It also doesnt appear to like feeds.

From what I can tell we should be able to update the allowed protocols stored in the UrlHelper object. I added
UrlHelper::setAllowedProtocols(Feed::getSupportedSchemes()); to the form build function and was able to print out the updated protocols in the isValid handler. Unfortunately the isValid handler isnt taking the allowedProtocols into consideration, and is instead relying on the hard coded regex mentioned above. Swapping out the current text for something like

$allowedProtocols = implode('|', UrlHelper::getAllowedProtocols());

    if ($absolute) {
      return (bool) preg_match("
        /^                                                      # Start at the beginning of the text
        (?:" . $allowedProtocols . "):\/\/                                # Look for allowed schemes
        (?:

fixes the issue.

It looks like this is a known issue in core. Added a related issue that is looking into this: https://www.drupal.org/node/2691099

Do we want to postpone this and wait for the core updates, work around the isValid limitation, or call this as fixed as it can be and open another ticket to wait for the core updates?

Queued the most recent patch for retesting, as the original tests didnt report any errors and my simplytest.me instance came back clean

Moving to needs review as all the retests passed. Do you think we need additional unit tests for these items?

I'll give it a go. That's one of the things I need to get better at...

Sorry for the delay on this one. I gave this an initial go but I'm running into trouble trying to get test results. I just spun up a simplytest.me instance and ran some of the feeds tests and Im getting the same result as my local - 0 tests run

a small sample:
Overall results: 0 passes, 0 fails, 0 exceptions
Drupal\Tests\feeds\Unit\Feeds\Fetcher\Form\HttpFetcherFormTest: 0 passes, 0 fails, 0 exceptions
Drupal\Tests\feeds\Unit\Feeds\Fetcher\Form\DirectoryFetcherFormTest: 0 passes, 0 fails, 0 exceptions
Drupal\Tests\feeds\Unit\Feeds\Fetcher\Form\DirectoryFetcherFeedFormTest: 0 passes, 0 fails, 0 exceptions
Drupal\Tests\feeds\Unit\FeedImportHandlerTest: 0 passes, 0 fails, 0 exceptions

I based my initial attempt on the DirectoryFetcherFeedFormTest as it seemed similar enough for a rough start. I noticed that all the tests running under the feeds\Tests namespace are firing were as the Drupal\Tests\feeds\Unit items arent firing. Should I be testing them in a different manner?

Hi @blastoise
I just spun up a clean install on simplytest.me with only feeds 8.x-3.x installed. I created a new feed type with a download fetcher and csv parser, then added a feed with the URL example.com/test_csv_to_import.csv. That doesn't validate because it's missing the protocol, but saving the feed with http://example.com/test_csv_to_import.csv went through with no error. I got an error when the feed tried to run because it isn't a real page, but that makes sense (Client error: `GET http://example.com/test_csv_to_import.csv` resulted in a `404 Not Found). If you try the url with the protocol and still receive an error please open a new issue with the steps to reproduce so that we can dive in.

In regards to tests for the above patch I ran into some issues getting the test suite to run on windows but eventually got around those problems using a docker instance instead. Nothing like sidestepping the problem entirely! I'm getting an odd error regarding a retrn by reference error that needs fixing before I can put a patch up. I'll take another crack at it soon and then, if I cant make it work, I'll drop into IRC to see if I cant rustle up some help.

I think I found it. Check your feed type settings and uncheck the 'Auto detect feeds' checkbox in the Fetcher settings tab and see if that works. I think that kicks an error if it cant find something resembling a properly formatted feed in the destination. Since you are using a csv file there is no feed.