Closed (fixed)
Project:
Feeds
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Apr 2016 at 16:23 UTC
Updated:
19 May 2016 at 09:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
megachrizThe form to import Feeds importers was modelled after how Views deals with importing/overriding views.
Appearantly, Views will just import the view with no warning if you import one that overrides a default view, even if you don't check the option "Replace an existing view if one exists with the same name". This option was added in #421842: Allow imported views to overwrite existing views. Before that, views saved in the database could not be overriden using the import form, but default views still could. The option were default views could be overriden using the import form was added with the rest of the import form logic: http://cgit.drupalcode.org/views/commit/?h=master&id=1008b7ff61e47df3452...
Anyway, to me it looks like #421842: Allow imported views to overwrite existing views overlooked to validate the possibility that default views could get overwritten with a new imported view and that it wasn't intentional.
Seems like this is an issue in both Feeds and Views. Opinions?
Comment #3
megachrizReuploading the patch from the issue summary so it will be evaluated by the testbot.
Comment #4
alan-ps commentedThanks for your response. Created appropriate issue for views module: https://www.drupal.org/node/2708503
Comment #6
megachrizI've waited for a response on #2708503: Import views ignores validation. to hear for any arguments against this change, but no one responded on that and I'm fine with the change. Should there come a good argument on that issue, we can always revert this change.
Committed #3.
Comment #7
megachrizWoops, I had meant to make you the commit author. Sorry :$.
Comment #8
alan-ps commentedThanks :)